| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a component with the same name and equal version is available from
both remote repository and installer binary, it makes more sense to
use the installer resource as the package source for the component.
This also fixes the issue of erroneously registering duplicate archives
to a single resource collection. Because both the internal resources and
downloaded archives are registered in the same naming scheme of
"installer://<component>/<version><archive>", we would register the
same archive second time when using the remote source. If the packager
has not explicitly added Extract operations for the component, these
would be created automatically by looking for archive entries from the
component's resource collection, and so the same operation would be
added twice.
Task-number: QTIFW-2242
Change-Id: I82d4ed8a94a67d982b016bf7cec972e43bef8f03
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Autodependencies can be added also from script. The uninstaller and
installer calculators ignored the values set from script depending on at
what state of the script run the autodependencies were added. Fixed so
that at any point the autodependencies are added from script, the
installer and uninstaller calculators has correct values.
Change-Id: If993bcce72f889b51e4b981473540c4e1ccd6067
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If component is updated to repository, and new dependencies are added,
the dependencies should be installed only when fresh install to
component is made or the component is updated.
This change adds a new LocalDependencies value to component. It keeps
track of the dependencies the local installed packages has.
Fixes also a bug in uninstallecalculator, where we should also read the
dependencies from local installed packages instead of newly introduced
repositories.
Task-number: QTIFW-2624
Change-Id: I0557e5adf1e87c0a1238cc455cfb2c90f6b05c87
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Autodependency components were always forcely updated, even if 'Deselect
All' was selected in component selection page. Fixed so that the
autodependency component update is updated only when one of its
dependants is updated.
Task-number: QTIFW-2595
Change-Id: I05ececc45ef32ff80d53b008f839b358158a3316
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Before this change, components that declared explicit SortingPriority
value would be sorted incorrectly with the default sorting value if the
repositories were not available after installation.
Task-number: QTIFW-2631
Change-Id: I3d18d6c6a5444eb3d2d700f12ed61da72431b8a4
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
| |
This makes the output more consistent between operations in Unpack
and Install phase and removes the need to hard code some print
to the operation side.
Change-Id: Ia955f479cb138fcf0ffd6a73a06de6a74df6ed13
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No need to recalculate local installed components if no changes has been
made. This makes the component selection quicker if there are lots
of components to be installed.
Local components are already calculated and listed in LocalPackageHub.
Using this class directly instead of calculating own local component
hash table. This changes the localInstalledPackages() from QHash to QMap,
which is not as optimized for searching components, but overall performance
is still now way better.
Task-number: QTIFW-2522
Change-Id: I8c16060f4b4014f740be0c7c43ece5e659d92987
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed unnecessary dependency component calculation for unstable
components. We mark the dependee components unstable already in
setUnstable() -function where we mark the original component unstable.
This change speeds up building the component tree from zero to fifty
percent depending on the number of script all components have.
Task-number: QTIFW-2626
Change-Id: I11b35cfd981cea8b8ed958a5af51b695cc47e9c5
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
| |
Change-Id: I9089e814426e177d5af38d19363cdd97189fa0d3
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Single items check state is not tracked anywhere else but in the model,
so we do not need to send dataChanged -signal to every item when the
model check state changes. The correct check state is already set to
every item above, so this emit seems unnecessary. This has significant
effect on 'Select All', 'Deselect All' and 'Default' -buttons. If there
are hundreds of items in the tree, this speeds up the button press in
best case over 50 percent.
Task-number: QTIFW-2623
Change-Id: If3c2aaebcc0dd6619179c31a51c8a57fdcec5c66
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes maintenance tool startable from Launchpad and Spotlight
search. Add "MaintenanceToolAlias" configuration variable for
setting the name of the alias, which may differ from the actual
file name in installation directory.
Task-number: QTIFW-2535
Task-number: QTIFW-2478
Change-Id: I73ae5bbf5d0196b2512b5517cb02c391b2ab278c
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Windows, extracting archives containing same files and directories
would sometimes cause "Can't unlink already-existing object: Permission
denied" error when replacing existing files.
This was caused by releasing the FileGuard lock object for the archive
entry without ensuring the entry was closed. Normally libarchive clients
do not need to care about this, as the entry is closed automatically
by archive_write_header() and archive_write_close() as required, but in
our case there is a need access synchronization because archives can
extract entries with the same entry paths in parallel.
Fix by calling archive_write_finish_entry() before releasing the lock,
so that no file handles are left open and no file attribute changes
are left pending for the implicit closing on writing the next entry
header.
Task-number: QTIFW-2620
Change-Id: I7e7322927964296c3b32ef4a052a91f1ba29aac3
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
| |
Also use the typedefs in the code when possible.
Change-Id: Ie5aa55997051afc864de87d58a10db1c33312ff2
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
|
|
| |
This looks better when the pixmap cannot be scaled to the entire
viewport because of its aspect ratio.
Change-Id: I5826412124363ab38cb07dcc35ff5387e8baa380
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a lot of components are installed, maintenancetool was slow to
select/unselect a single component. This was caused because the whole
tree's components were recalculated. Fixed so that only the
selected/unselected components and their dependencies and
autodependencies are recalculated instead of whole tree.
This change speeds up clicking tree item from zero to 90 percent,
depending on how much components are already installed. The more
components are installed as autodependency, the slower it gets to
select the items.
Task-number: QTIFW-2522
Change-Id: I5e824aed8787fd7ecdce72b15a1b13848f0a3923
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't print the name of every single removed file and directory unless
the verbosity level is set to detailed, as this really chokes the UI
thread.
QPlainTextEdit would have had better performance for a real-time output
log widget than QTextEdit, but we cannot use it as we require support
for displaying and automatically aligning text also for RTL languages.
Task-number: QTIFW-2615
Change-Id: Ie2938941b32bb387c0528b894cd058f395561814
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
| |
Some licenses use ASCII art to display tables, etc. which requires
that the font is of fixed width.
Task-number: QTIFW-2613
Change-Id: I0f473e6320912702c5df01d99a573ee820da3c1b
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
| |
Before this change we would print a warning for each operation when
iterating over the results of their asynchronous execution. These are
unnecessary as canceling is a conscious action from the user.
Change-Id: I2b9bd469b3a3e1c9794c6f2c4952896640cd88da
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
| |
Some of the error paths, especially when packaging archives, gave
too vague information about what went wrong.
Change-Id: I04388a6d333533fb370a472fa82d9562b17df37e
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At least with the 7z format packaged with a recent archivegen version,
the directory entries from archives get processed last when extracting.
We remember the path of each extracted entry in the order the writing
happens, to be able to undo the extract later.
The directories need to be empty for the removing to succeed, so we
cannot rely that the entry order from extraction is correct. Ensure
files are removed before directories and that the directories are
removed in an order starting from the deepest subdirectory level.
Task-number: QTIFW-2594
Change-Id: I8a914c4bf69147b845b12f0481c49c93408b51fd
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
For tracing issues with the multithreaded extraction and limiting the
processor load from the installer.
Task-number: QTIFW-2586
Change-Id: I5df0bf6be30b4ee5ef8470c407281e2a4318ed0c
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
In a similar fashion to the archive download status, display:
* Performed operations - total operations, on unpack.
* Installed components - total components, on install.
* Rolled back operations - total undo operations, on uninstall.
Task-number: QTIFW-2513
Change-Id: I61690a25afadd1ca1e4a46b5b980ac094429135b
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the progress appear smoother when the archives to extract
differ in size.
The sorting based on the archive sizes provides some improvement to
optimal thread utilization, as the larger archives get more time to
complete from the start. We are less likely to find ourselves in a
situation where any of the last operations left to be run with less
than ideal thread count take significantly more time to complete than
the others.
Task-number: QTIFW-2431
Change-Id: I2534b6f18997d73c4ce1fb8b26900e30e1c6a76f
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce ConcurrentOperationRunner class used for running
installer operations concurrently in the global thread pool.
Add execution groups for operations; Unpack operations are run
concurrently for all components requesting installation,
operations belonging to Install group are run sequentially for
sorted components one at a time as before. From the default
registered operations the Extract op is moved to Unpack group.
Move the previously on-the-fly backup steps of Extract operation
to the ExtractArchiveOperation::backup(), so that backups are
done before any archives are extracted, and that we know if any
of the archives requires administrator privileges to unpack.
Reparent QInstaller::Error to QException to support throwing
and catching exceptions across thread boundaries.
Use RAII for the server-side objects of the classes supporting
the remote client-server protocol of installer framework. The
concurrent extraction revealed that it was still possible that
the local socket was disconnected and thus the RemoteServer-
Connection thread finished before receiving and processing the
final "Destroy" command packet, leaking the dynamically
allocated objects.
Task-number: QTIFW-2566
Change-Id: Ib8c2928b9405b7b3465c731018df73acb51e949f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Components were recalculated when leaving the tree view. This is
unnecessary as we have just calculated the components. Moving the
recalculation to Introduction page so alternate pressing of 'Add or
remove components' and 'Update components' will cause the recalculation
as we need that to keep the component install states in sync.
Task-number: QTIFW-2598
Task-number: QTIFW-694
Change-Id: Ia84a01b4f1d0b39b4844c02470b764c4940e943c
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The function signature for setting a pixmap for the label changed
from 'setPixmap(const QPixmap &pixmap)' to
'setPixmapAndUrl(const QPixmap &pixmap, const QString &url)' when
we enabled support for click URLs.
Redefine (again) the base class QLabel::setPixmap() slot to make
it harder for callers to set non-scaled pixmaps accidentally. This
is still a bit bad however as it is possible to get different
client-visible results by calling the method with a base class
pointer.
Task-number: QTIFW-2612
Change-Id: Ic79b3d71ffd5baf2108768ad3b867ddbcb33833b
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has been already fixed but the change was overwritten by
a merge commit.
From original commit message:
QStandardPaths::standardLocations(QStandardPaths::ApplicationsLocation)
first element returns $HOME/Applications, as being user writable it
has a higher priority.
Change the variable to return system wide /Applications as it is
a more expected default.
Task-number: QTIFW-1011
Change-Id: Iff4f65450db03ed412d4cb97db5f294bf52ffc72
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
The "Cancel" button on bottom of the wizard is also missing a shortcut.
But this behavior is inherited from QWizard, where it appears to be
intentional.
Task-number: QTIFW-2206
Change-Id: I53e595591679f5d22b2b381f86974dfc963d2bd4
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
| |
Release details:
https://github.com/libarchive/libarchive/releases/tag/v3.6.1
Change-Id: I57275393c785195cf0ae19bfc59be42c7c5e4875
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
| |
Also add attribution document.
Task-number: QTIFW-2336
Change-Id: I91546bc6c3ace244e4b546b945f40b7d204f7463
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The 3rd-party sources haven't been updated in a long time, and
is missing some features compared to libarchive (which the
official IFW binaries use), like symbolic link support on Windows.
Add deprecation warning when compiling with LZMA SDK, and make
building the library and related client code conditional behind
a separate config feature.
Update docs to emphasize that libarchive is the recommended build
option for archive handler.
Change-Id: I70ed5f9b5d13e2243778f7c44b4ea833c8092ae0
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
| |
Task-number: QTIFW-2269
Change-Id: I7ec5931e8475a3477ba2c05ba9e8ed0620b02206
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
| |
Compiling the update resource doesn't require specifying a package
or repository directory.
Change-Id: I2a8541b610e90755fb49ae9568ac7ee0756e3058
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Also print a general message when no components from the user selection
are valid - in case the installer misses the detailed reason why
components cannot be selected, at least some information is printed.
Task-number: QTIFW-2591
Change-Id: I1b10e7601527ddc0192417b41691691b517139a5
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Release details:
https://github.com/libarchive/libarchive/releases/tag/v3.6.0
Change-Id: Ia3d322ffbea70aad2713b7641832f6a56bb75645
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
In details view uninstallable and installable components are listed. For
installable components a reason is shown why the component is installed.
Added similar kind of message for uninstallable components as well.
Task-number: QTIFW-2581
Change-Id: Idbf31200793a6c89a4ed4a6fc115f49889b5f9b5
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|\
| |
| |
| | |
Change-Id: I449320b3af2c561a0b4a4cb689d072533d8fdb8f
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Replaced component was uninstalled when installing other components
although no update or install was requested to the component. Fixes also
a bug when some components were uninstalled unvisible from user.
Task-number: QTIFW-2577
Change-Id: I6a7e9ce4a56991dfbdea53eb376d782dfb5d050a
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Components might be uninstalled also in updater view, for example if the
component is replaced with another components. This was not shown to the
user.
Task-number: QTIFW-2576
Change-Id: I143324eeb4830d15a718005992b3cb35d0f6696d
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Virtual dependencies are uninstalled if all dependencies to the
component is removed. Virtual dependencies were calculated using recent
components in repository, which is wrong as the dependencies may have
changed in the repository, causing the dependencies to be uninstalled
although those are still needed. Fixed so that the uninstallable virtual
components are calculated from repository components if the component is
going to be updated, otherwise the dependeny is calculated from the
local installed packages.
Task-number: QTIFW-2573
Change-Id: If9cc59fa7f453d502ec1883f27273ef604128a6e
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 270c5dfd9b6c86bec8eaf34d0a2c3d3b945ed5e5.
Reason for revert: This caused a regression when an absolute path pointing to a directory non-writable by current user was used.
QTemporaryFile uses its own file engine so we need to use QFile
instead to forward the calls to the elevated privilege installer
process with the Qt Installer Framework's RemoteFileEngine.
Task-number: QTIFW-2575
Change-Id: I47f5bea06f9e1689ee322d972b405d8127967a98
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Product image can now be clicked. It opens either url in Web browser or
if file reference is given, then it will be opened with the suitable
application.
Task-number: QTIFW-2361
Change-Id: I59ed1355e90c23c8d0a5124779725825ca1ee2c8
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I29827c4197249b289641693b691a8a5d72277458
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|\|
| |
| |
| | |
Change-Id: I4c2d440a82ceb4d48a97c78fa14fb15cc56596f0
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This bug was caused by the previous change which allowed the Windows
separators to be saved to dat file without converting to normalized
separators
Task-number: QTIFW-2501
Change-Id: Iaeb70da0eaaa5c677c72178fcb8b336bc50a6842
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If there was at least one valid component argument, the installer would
silently ignore any invalid component arguments.
Instead print the appropriate "cannot install" reason for such
components but still don't block installation for others.
Change-Id: I7325d151385744ac46fcb5fa04c0eaf6acade3f3
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|\|
| |
| |
| | |
Change-Id: I8204fdbae2602f3dfb6eb04dc28d2e59606594ea
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Libarchive stores most paths internally in a multistring that can
contain a combination of a wide character string, multibyte string in
current locale or unicode string encoded as UTF-8. Try to retrieve and
set a variant of the string with the correct encoding when converting
libarchive strings to/from Qt string classes.
Task-number: QTIFW-2506
Change-Id: I7e7c1e3c5709b669df68b2f3918789ad4ebe4f13
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Execute -operation might be strict with the path separators. If wrong
separators are used the Execute -operation might fail. Fixed so that
Execute -operations paths are saved to dat file without converting to
normalized separators. As the target dir is saved as @RELOCATABLE_PATH@
also for Execute -operation, check from the next available separator
which separator should be used for operation.
Task-number: QTIFW-2501
Change-Id: Ia9969bbe3177a6b2daab21c026df88d4e2ec2bb0
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Sometimes the textual error message returned by archive_error_string()
does not reveal enough useful information, add also the error code from
archive_errno().
Change-Id: Icc62168bc862484bfa1efc70dd8ca2e341b3394f
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|