From 4744ad130a2d4310e812a89da22d36a2e885b281 Mon Sep 17 00:00:00 2001 From: Katja Marttila Date: Tue, 10 Dec 2019 12:23:08 +0200 Subject: Do not show error dialog when filelist for uninstall not found This error can occur for example when user has manually deleted the installerResource folder or files inside it or the same component has been installed multiple times (QTIFW-1502). Change-Id: I8007a2f99517b4f90902ed3b740027d54371d119 Reviewed-by: Jani Heikkinen --- src/libs/installer/extractarchiveoperation.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/libs/installer/extractarchiveoperation.cpp b/src/libs/installer/extractarchiveoperation.cpp index ba0591c84..b5bf96954 100644 --- a/src/libs/installer/extractarchiveoperation.cpp +++ b/src/libs/installer/extractarchiveoperation.cpp @@ -212,10 +212,11 @@ bool ExtractArchiveOperation::readDataFileContents(QString &targetDir, QStringLi resultList->replace(i, replacePath(resultList->at(i), QLatin1String(scRelocatable), targetDir)); } else { - setError(UserDefinedError); - setErrorString(tr("Cannot open file \"%1\" for reading: %2") - .arg(QDir::toNativeSeparators(file.fileName())).arg(file.errorString())); - return false; + // We should not be here. Either user has manually deleted the installer related + // files or same component is installed several times. + qWarning() << "Cannot open file " << file.fileName() << " for reading:" + << file.errorString() << ". Component is already uninstalled " + << "or file is manually deleted."; } return true; } -- cgit v1.2.3