From d5be955bbb6cf595f7f6c30c4b1904c153a4d7c7 Mon Sep 17 00:00:00 2001 From: Katja Marttila Date: Mon, 28 May 2018 11:52:24 +0300 Subject: Print component warnings only in verbose mode If there are lot of components, it takes a lot of time to check every component for their errors. Print those only when --verbose given in command line. Task-number: QTIFW-975 Change-Id: If9467416d5d8f3417cd30262f95e91308a79e7a6 Reviewed-by: Iikka Eklund --- src/libs/installer/packagemanagercore_p.cpp | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/libs/installer/packagemanagercore_p.cpp b/src/libs/installer/packagemanagercore_p.cpp index 1cd7811c7..78482b411 100644 --- a/src/libs/installer/packagemanagercore_p.cpp +++ b/src/libs/installer/packagemanagercore_p.cpp @@ -406,11 +406,14 @@ bool PackageManagerCorePrivate::buildComponentTree(QHash &c restoreCheckState(); - foreach (QInstaller::Component *component, components) { - const QStringList warnings = ComponentChecker::checkComponent(component); - foreach (const QString &warning, warnings) - qCWarning(lcComponentChecker).noquote() << warning; + if (m_core->isVerbose()) { + foreach (QInstaller::Component *component, components) { + const QStringList warnings = ComponentChecker::checkComponent(component); + foreach (const QString &warning, warnings) + qCWarning(lcComponentChecker).noquote() << warning; + } } + } catch (const Error &error) { clearAllComponentLists(); emit m_core->finishAllComponentsReset(QList()); -- cgit v1.2.3