From f9aea76b0a255e2b8e9b792582229077f374fa5e Mon Sep 17 00:00:00 2001
From: Katja Marttila <katja.marttila@qt.io>
Date: Wed, 3 Mar 2021 13:47:17 +0200
Subject: Cppcheck: Initialize uninitialized member variables

Change-Id: I38c52e2412f50e0aba41876112a66956b9de2920
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
---
 src/libs/installer/component_p.cpp             | 1 +
 src/libs/installer/performinstallationform.cpp | 1 +
 src/libs/kdtools/filedownloader.cpp            | 2 +-
 src/libs/kdtools/selfrestarter.cpp             | 1 +
 src/libs/kdtools/updatefinder.cpp              | 1 +
 5 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/libs/installer/component_p.cpp b/src/libs/installer/component_p.cpp
index 8533d8e4c..0f74e423c 100644
--- a/src/libs/installer/component_p.cpp
+++ b/src/libs/installer/component_p.cpp
@@ -54,6 +54,7 @@ ComponentPrivate::ComponentPrivate(PackageManagerCore *core, Component *qq)
     , m_autoCreateOperations(true)
     , m_operationsCreatedSuccessfully(true)
     , m_updateIsAvailable(false)
+    , m_unstable(false)
 {
 }
 
diff --git a/src/libs/installer/performinstallationform.cpp b/src/libs/installer/performinstallationform.cpp
index 2fb6026cc..31b61ceeb 100644
--- a/src/libs/installer/performinstallationform.cpp
+++ b/src/libs/installer/performinstallationform.cpp
@@ -80,6 +80,7 @@ PerformInstallationForm::PerformInstallationForm(QObject *parent)
     : QObject(parent)
     , m_progressBar(nullptr)
     , m_progressLabel(nullptr)
+    , m_downloadStatus(nullptr)
     , m_productImagesScrollArea(nullptr)
     , m_productImagesLabel(nullptr)
     , m_detailsButton(nullptr)
diff --git a/src/libs/kdtools/filedownloader.cpp b/src/libs/kdtools/filedownloader.cpp
index 4cccfd9ca..a9f5040f0 100644
--- a/src/libs/kdtools/filedownloader.cpp
+++ b/src/libs/kdtools/filedownloader.cpp
@@ -192,6 +192,7 @@ struct KDUpdater::FileDownloader::Private
         : m_hash(QCryptographicHash::Sha1)
         , m_assumedSha1Sum("")
         , autoRemove(true)
+        , followRedirect(false)
         , m_speedTimerInterval(100)
         , m_downloadDeadlineTimerInterval(30000)
         , m_downloadPaused(false)
@@ -255,7 +256,6 @@ KDUpdater::FileDownloader::FileDownloader(const QString &scheme, QObject *parent
     , d(new Private)
 {
     d->scheme = scheme;
-    d->followRedirect = false;
 }
 
 /*!
diff --git a/src/libs/kdtools/selfrestarter.cpp b/src/libs/kdtools/selfrestarter.cpp
index e94d0fea7..7326ac070 100644
--- a/src/libs/kdtools/selfrestarter.cpp
+++ b/src/libs/kdtools/selfrestarter.cpp
@@ -45,6 +45,7 @@ public:
     }
 
     Private()
+        : restartOnQuit(false)
     {
         executable = qApp->applicationFilePath();
         workingPath = QDir::currentPath();
diff --git a/src/libs/kdtools/updatefinder.cpp b/src/libs/kdtools/updatefinder.cpp
index 535dfde3d..3403430fe 100644
--- a/src/libs/kdtools/updatefinder.cpp
+++ b/src/libs/kdtools/updatefinder.cpp
@@ -81,6 +81,7 @@ public:
 
     Private(UpdateFinder *qq)
         : q(qq)
+        , cancel(false)
         , downloadCompleteCount(0)
         , m_downloadsToComplete(0)
     {}
-- 
cgit v1.2.3