From faa8f39bdd8c13b21c19bec1592f18e710c56206 Mon Sep 17 00:00:00 2001 From: Iikka Eklund Date: Mon, 13 Jan 2014 11:59:10 +0200 Subject: ApplyProductKeyOperation::performOperation should return correctly The ApplyProductKeyOperation::performOperation should return false whent the actual operation has failed. Currently even if the operation fails and returns false the installer will keep on installing without user interaction. Change-Id: I68020f8200cebbc45bca164d66fb876e170f3721 Reviewed-by: Antti Kokko Reviewed-by: Kai Koehne Reviewed-by: Tim Jenssen --- src/libs/installer/applyproductkeyoperation.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libs/installer/applyproductkeyoperation.cpp b/src/libs/installer/applyproductkeyoperation.cpp index 4556df743..5b561bd19 100644 --- a/src/libs/installer/applyproductkeyoperation.cpp +++ b/src/libs/installer/applyproductkeyoperation.cpp @@ -46,6 +46,7 @@ bool ApplyProductKeyOperation::performOperation() if (!ProductKeyCheck::instance()->applyKey(arguments())) { setError(UserDefinedError); setErrorString(ProductKeyCheck::instance()->lastErrorString()); + return false; } return true; } -- cgit v1.2.3