From 6264882398534b35aef081d52a7d974f98b48101 Mon Sep 17 00:00:00 2001 From: Arttu Tarkiainen Date: Wed, 28 Oct 2020 13:12:02 +0200 Subject: Add missing members to PackageManagerCorePrivate member initializer list The lesser called class constructor function was missing initialization for some of the fundamental data type member variables. This could cause weird behavior in autotests, where a PackageManagerCore object for "fake" installers is instantiated on multiple occasions. Change-Id: I4e65453e3125cb5b4b662314a593bb0232907478 Reviewed-by: Katja Marttila --- src/libs/installer/packagemanagercore_p.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'src/libs/installer/packagemanagercore_p.cpp') diff --git a/src/libs/installer/packagemanagercore_p.cpp b/src/libs/installer/packagemanagercore_p.cpp index 4449509e5..edbf6459d 100644 --- a/src/libs/installer/packagemanagercore_p.cpp +++ b/src/libs/installer/packagemanagercore_p.cpp @@ -208,10 +208,18 @@ PackageManagerCorePrivate::PackageManagerCorePrivate(PackageManagerCore *core) : m_updateFinder(nullptr) , m_compressedFinder(nullptr) , m_localPackageHub(std::make_shared()) + , m_status(PackageManagerCore::Unfinished) + , m_needsHardRestart(false) + , m_testChecksum(false) + , m_launchedAsRoot(AdminAuthorization::hasAdminRights()) + , m_completeUninstall(false) + , m_needToWriteMaintenanceTool(false) + , m_dependsOnLocalInstallerBinary(false) , m_core(core) , m_updates(false) , m_repoFetched(false) , m_updateSourcesAdded(false) + , m_magicBinaryMarker(0) // initialize with pseudo marker , m_componentsToInstallCalculated(false) , m_componentScriptEngine(nullptr) , m_controlScriptEngine(nullptr) -- cgit v1.2.3