From 74883726deeebea14faca65663339271f1c2c547 Mon Sep 17 00:00:00 2001 From: Arttu Tarkiainen Date: Thu, 6 Jan 2022 13:29:23 +0200 Subject: Fix segfaults when failing to fetch compressed repositories The ComponentModel object was not always reset in case we already got to the point of clearing the source data (deleted components owned by PackageManagerCore from previous fetch) and failed after that, leaving the model with dangling pointers to the deleted component objects. If we were already on ComponentSelectionPage, this would cause segmentation faults when the component tree view using the model would be shown again after fetch. Task-number: QTIFW-2441 Change-Id: Ie779de5ca0a3c4ae895ea507e6be4a2f7343501e Reviewed-by: Katja Marttila --- src/libs/installer/packagemanagercore_p.cpp | 1 - 1 file changed, 1 deletion(-) (limited to 'src/libs/installer/packagemanagercore_p.cpp') diff --git a/src/libs/installer/packagemanagercore_p.cpp b/src/libs/installer/packagemanagercore_p.cpp index 948093ad7..38909b4ea 100644 --- a/src/libs/installer/packagemanagercore_p.cpp +++ b/src/libs/installer/packagemanagercore_p.cpp @@ -474,7 +474,6 @@ bool PackageManagerCorePrivate::buildComponentTree(QHash &c } catch (const Error &error) { clearAllComponentLists(); - emit m_core->finishAllComponentsReset(QList()); setStatus(PackageManagerCore::Failure, error.message()); // TODO: make sure we remove all message boxes inside the library at some point. -- cgit v1.2.3