From 6163fc05768b6a7d05530ef5c33d8f024ebd6b6d Mon Sep 17 00:00:00 2001 From: Katja Marttila Date: Tue, 18 Feb 2020 13:55:25 +0200 Subject: CLI: decrease the amount of default debug prints Debug prints can be suppressed or extended with logging rules. Make the default usage so that only relevant information will be shown to user, such as uninstall/install progress, server information, warning messages and package name, version and displayname. Change-Id: I09be754a36dd97530d75cdea3edb5fc77e67a856 Reviewed-by: Iikka Eklund --- src/libs/kdtools/filedownloader.cpp | 2 +- src/libs/kdtools/filedownloaderfactory.cpp | 2 +- src/libs/kdtools/updateoperation.cpp | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) (limited to 'src/libs/kdtools') diff --git a/src/libs/kdtools/filedownloader.cpp b/src/libs/kdtools/filedownloader.cpp index f134ce883..b816b5fd5 100644 --- a/src/libs/kdtools/filedownloader.cpp +++ b/src/libs/kdtools/filedownloader.cpp @@ -1575,7 +1575,7 @@ void KDUpdater::HttpDownloader::onSslErrors(QNetworkReply* reply, const QList(QLatin1String("https")); else - qCWarning(QInstaller::lcGeneral) << "Cannot register file downloader for https protocol: QSslSocket::supportsSsl() returns false"; + qCWarning(QInstaller::lcInstallerInstallLog) << "Cannot register file downloader for https protocol: QSslSocket::supportsSsl() returns false"; #endif d->m_followRedirects = false; diff --git a/src/libs/kdtools/updateoperation.cpp b/src/libs/kdtools/updateoperation.cpp index b95f6f5a3..0a61c0105 100644 --- a/src/libs/kdtools/updateoperation.cpp +++ b/src/libs/kdtools/updateoperation.cpp @@ -249,7 +249,7 @@ QString UpdateOperation::argumentKeyValue(const QString &key, const QString &def it = std::find_if(++it, tArguments.end(), StartsWith(keySeparater)); if (it != tArguments.end()) { - qCWarning(QInstaller::lcGeneral).nospace() << "There are multiple keys in the arguments calling " + qCWarning(QInstaller::lcInstallerInstallLog).nospace() << "There are multiple keys in the arguments calling " << name() << ". " << "Only the first found " << key << " is used: " << arguments().join(QLatin1String("; ")); } @@ -518,7 +518,7 @@ bool UpdateOperation::fromXml(const QString &xml) int errorLine; int errorColumn; if (!doc.setContent( xml, &errorMsg, &errorLine, &errorColumn)) { - qCWarning(QInstaller::lcGeneral) << "Error parsing xml error=" << errorMsg + qCWarning(QInstaller::lcInstallerInstallLog) << "Error parsing xml error=" << errorMsg << "line=" << errorLine << "column=" << errorColumn; return false; } -- cgit v1.2.3