diff options
| author | Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io> | 2018-10-11 17:45:43 +0200 |
|---|---|---|
| committer | Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io> | 2018-11-22 17:00:11 +0000 |
| commit | a57a202a70801f766094c3ed11664b03c9a6a3e4 (patch) | |
| tree | 73c2c1f4fc902ccbc10b73811bbf299a2c555728 /sources/pyside2/PySide2/QtCharts/typesystem_charts.xml | |
| parent | f93a7369657814206bfbce49817c8fbd9a1bfcba (diff) | |
Move inject-code snippets to separate files
When code must be modified or added to certain
functions, we currently have two options:
* Write a template and include it into the typesystem,
* inject code directly at a certain place of the function entry.
The problem with injecting raw code is that since it is an XML
file, one need to escape protected symbols, like "<" and "&".
Thanks to a couple of complementary commits, now we can place
this code snippets on a separate file without triggering
a whole module compiling process, since the typesystem itself
will not be alterered.
All the injected code from the typesystem was removed
and placed into a single file per module inside a top-level directory
called glue.
Some small fixes were included mainly regarding styling
of the code.
Task-number: PYSIDE-834
Change-Id: I823e92d241a528d75d5940090008db9bf297f49e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Diffstat (limited to 'sources/pyside2/PySide2/QtCharts/typesystem_charts.xml')
| -rw-r--r-- | sources/pyside2/PySide2/QtCharts/typesystem_charts.xml | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/sources/pyside2/PySide2/QtCharts/typesystem_charts.xml b/sources/pyside2/PySide2/QtCharts/typesystem_charts.xml index ebcd09b18..14224751c 100644 --- a/sources/pyside2/PySide2/QtCharts/typesystem_charts.xml +++ b/sources/pyside2/PySide2/QtCharts/typesystem_charts.xml @@ -40,7 +40,7 @@ ****************************************************************************/ --> <typesystem package="PySide2.QtCharts"> - <load-typesystem name="QtWidgets/typesystem_widgets.xml" generate="no" /> + <load-typesystem name="QtWidgets/typesystem_widgets.xml" generate="no"/> <namespace-type name="QtCharts"> <object-type name="QAbstractAxis" since="5.7"> <enum-type name="AxisType"/> @@ -164,14 +164,10 @@ </modify-argument> </modify-function> <modify-function signature="removeAxis(QtCharts::QAbstractAxis*)"> - <inject-code> - Shiboken::Object::releaseOwnership(%PYARG_1); - </inject-code> + <inject-code file="../glue/qtcharts.cpp" snippet="qchart-releaseownership"/> </modify-function> <modify-function signature="removeSeries(QtCharts::QAbstractSeries*)"> - <inject-code> - Shiboken::Object::releaseOwnership(%PYARG_1); - </inject-code> + <inject-code file="../glue/qtcharts.cpp" snippet="qchart-releaseownership"/> </modify-function> </object-type> <object-type name="QChartView" since="5.7"> |