diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-01-16 15:45:10 +0100 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-01-17 10:07:55 +0000 |
| commit | 181fa70b7ba06c92c3c0fdc4c70081b14e4b1bdf (patch) | |
| tree | 3342c5f2020cf693594554b4f96bff6e8f39cf9c /sources/shiboken2/ApiExtractor/graph.cpp | |
| parent | 9d4c604943d73cb1c8f1a6dfdf9129f92bed0661 (diff) | |
shiboken: Fix some clazy warnings
- Mixing const/non-const iterators
- Do not use operator[] on temporaries of type QVector
- Remove unused nontrivial variables
- Add Q_FALLTHROUGH()
- Potential detach in range-based for
Change-Id: I89391fdda616f119eadd7de529eb6cee69343f85
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Diffstat (limited to 'sources/shiboken2/ApiExtractor/graph.cpp')
| -rw-r--r-- | sources/shiboken2/ApiExtractor/graph.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sources/shiboken2/ApiExtractor/graph.cpp b/sources/shiboken2/ApiExtractor/graph.cpp index e6ee660dc..6ba4d994a 100644 --- a/sources/shiboken2/ApiExtractor/graph.cpp +++ b/sources/shiboken2/ApiExtractor/graph.cpp @@ -127,8 +127,7 @@ void Graph::dumpDot(const QHash< int, QString >& nodeNames, const QString& fileN QTextStream s(&output); s << "digraph D {\n"; for (int i = 0; i < m_d->edges.size(); ++i) { - GraphPrivate::EdgeIterator it = m_d->edges[i].begin(); - for (;it != m_d->edges[i].end(); ++it) + for (auto it = m_d->edges[i].cbegin(), end = m_d->edges[i].cend(); it != end; ++it) s << '"' << nodeNames[i] << "\" -> \"" << nodeNames[*it] << "\"\n"; } s << "}\n"; |