Fix wrongly generated code for enums passed by const-ref

First encountered in:

QtScxmlEvent::setEventType(const EventType &);

The metatype was wrongly detected as NativePointerPattern
in AbstractMetaType::determineUsagePattern().
Introduce a helper for detecting plain const-ref and use
that consistently.

Change-Id: I6b105bc99ae63e4737c5d628e79f23b7acbcca3d
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>

2 files changed, 12 insertions, 0 deletions

diff --git a/sources/shiboken2/tests/libsample/objecttype.h b/sources/shiboken2/tests/libsample/objecttype.h
index 9d659faa4..bcb4f3332 100644
--- a/sources/shiboken2/tests/libsample/objecttype.h
+++ b/sources/shiboken2/tests/libsample/objecttype.h
@@ -53,6 +53,10 @@ struct Event
 
     Event(EventType eventType) : m_eventType(eventType) {}
     EventType eventType() { return m_eventType; }
+
+    void setEventType(EventType et) { m_eventType = et; }
+    void setEventTypeByConstRef(const EventType &et) { m_eventType = et; }
+
 private:
     EventType m_eventType;
 };
diff --git a/sources/shiboken2/tests/samplebinding/enum_test.py b/sources/shiboken2/tests/samplebinding/enum_test.py
index 0a5a84c4a..7e1cac8c0 100644
--- a/sources/shiboken2/tests/samplebinding/enum_test.py
+++ b/sources/shiboken2/tests/samplebinding/enum_test.py
@@ -115,6 +115,14 @@ class EnumTest(unittest.TestCase):
         sum = Event.EventTypeClass.Value1 + Event.EventTypeClass.Value2
         self.assertEqual(sum, 1)
 
+    def testSetEnum(self):
+        event = Event(Event.ANY_EVENT)
+        self.assertEqual(event.eventType(), Event.ANY_EVENT)
+        event.setEventType(Event.BASIC_EVENT)
+        self.assertEqual(event.eventType(), Event.BASIC_EVENT)
+        event.setEventTypeByConstRef(Event.SOME_EVENT)
+        self.assertEqual(event.eventType(), Event.SOME_EVENT)
+
     def testEnumTpPrintImplementation(self):
         '''Without SbkEnum.tp_print 'print' returns the enum represented as an int.'''
         tmpfile = createTempFile()