From 1067faec16032e2f71c72b8415605708a88adb66 Mon Sep 17 00:00:00 2001 From: Renato Filho Date: Mon, 4 Apr 2011 18:06:07 -0300 Subject: Change the order of function call on destructionVisitor to avoid problems with cyclic dependency. Fixes bug #793. Reviewer: Luciano Wolf Hugo Parente --- libpyside/pyside.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libpyside/pyside.cpp b/libpyside/pyside.cpp index ec710a517..a135692bf 100644 --- a/libpyside/pyside.cpp +++ b/libpyside/pyside.cpp @@ -113,10 +113,11 @@ static void destructionVisitor(SbkObject* pyObj, void* data) if (pyObj != pyQApp && PyObject_TypeCheck(pyObj, pyQObjectType)) { if (Shiboken::Object::hasOwnership(pyObj) && Shiboken::Object::isValid(pyObj, false)) { + Shiboken::Object::setValidCpp(pyObj, false); + Py_BEGIN_ALLOW_THREADS Shiboken::callCppDestructor(Shiboken::Object::cppPointer(pyObj, pyQObjectType)); Py_END_ALLOW_THREADS - Shiboken::Object::setValidCpp(pyObj, false); } } }; -- cgit v1.2.3