From c8438a7ce830aa3151f12e71721b9457b33be41d Mon Sep 17 00:00:00 2001 From: Hugo Parente Lima Date: Mon, 17 May 2010 18:24:15 -0300 Subject: Do not copy the QList, use a const reference instead. QList copy is cheap, because it's implicity shared, but const references are much more cheap indeed. --- abstractmetabuilder.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/abstractmetabuilder.cpp b/abstractmetabuilder.cpp index 4281b2b62..16047a64c 100644 --- a/abstractmetabuilder.cpp +++ b/abstractmetabuilder.cpp @@ -2623,11 +2623,7 @@ AbstractMetaClassList AbstractMetaBuilder::classesTopologicalSorted(const Abstra QHash map; QHash reverseMap; - AbstractMetaClassList classList; - if (cppClass) - classList = cppClass->innerClasses(); - else - classList = m_metaClasses; + const AbstractMetaClassList& classList = cppClass ? cppClass->innerClasses() : m_metaClasses; Graph graph(classList.count()); -- cgit v1.2.3