From 630a4062ff9d837ae0f91056ab610183bf47370a Mon Sep 17 00:00:00 2001 From: Renato Filho Date: Mon, 2 Aug 2010 14:55:50 -0300 Subject: Fixed ref leak on QMenu inject code. Reviewer: Marcelo Lira Luciano Wolf --- PySide/QtGui/glue/qmenu_glue.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'PySide/QtGui/glue') diff --git a/PySide/QtGui/glue/qmenu_glue.h b/PySide/QtGui/glue/qmenu_glue.h index 7f0475a2e..1a6cb19f3 100644 --- a/PySide/QtGui/glue/qmenu_glue.h +++ b/PySide/QtGui/glue/qmenu_glue.h @@ -13,8 +13,8 @@ addActionWithPyObject(QMenu *self, const QIcon& icon, const QString& text, PyObj self->addAction(act); PyObject *pyAct = Shiboken::Converter::toPython(act); - PyObject* result = PyObject_CallMethod(pyAct, "connect", "OsO", pyAct, SIGNAL(triggered()), callback); - if (result == 0) { + Shiboken::AutoDecRef result(PyObject_CallMethod(pyAct, "connect", "OsO", pyAct, SIGNAL(triggered()), callback)); + if (result.isNull()) { Py_DECREF(pyAct); return 0; } -- cgit v1.2.3