From b1f7791a7257b0fb5a766cd1825fb32d52403bee Mon Sep 17 00:00:00 2001 From: Renato Filho Date: Tue, 22 Jun 2010 18:08:25 -0300 Subject: Check for invalid signal or slot name. Reviewer: Hugo Parente Lima , Luciano Wolf --- PySide/QtCore/glue/qobject_connect.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'PySide') diff --git a/PySide/QtCore/glue/qobject_connect.cpp b/PySide/QtCore/glue/qobject_connect.cpp index e9de41144..535dd10da 100644 --- a/PySide/QtCore/glue/qobject_connect.cpp +++ b/PySide/QtCore/glue/qobject_connect.cpp @@ -25,6 +25,9 @@ static bool getReceiver(PyObject *callback, QObject **receiver, PyObject **self) static bool qobjectConnect(QObject* source, const char* signal, QObject* receiver, const char* slot, Qt::ConnectionType type) { + if (!signal || !slot) + return false; + if (!PySide::checkSignal(signal)) return false; signal++; @@ -39,7 +42,7 @@ static bool qobjectConnect(QObject* source, const char* signal, QObject* receive static bool qobjectConnectCallback(QObject* source, const char* signal, PyObject* callback, Qt::ConnectionType type) { - if (!PySide::checkSignal(signal)) + if (!signal || !PySide::checkSignal(signal)) return false; signal++; -- cgit v1.2.3