From 4d82ee992992251bcadf0097a4df60fe7c3b7ef8 Mon Sep 17 00:00:00 2001 From: Alexandru Croitor Date: Wed, 28 Nov 2018 14:57:31 +0100 Subject: Make it hard to use the create_pyside_module function incorrectly Rewrite the function to use keyword arguments instead of ordered arguments. Also add error detection when required arguments are not passed, or have a typo in them. Adjust all the module cmake files to use keyword arguments. Change-Id: I7bb0c6561d7dca1e7f673e29eb457da50ae5df04 Reviewed-by: Qt CI Bot Reviewed-by: Cristian Maureira-Fredes --- sources/pyside2/PySide2/Qt3DExtras/CMakeLists.txt | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) (limited to 'sources/pyside2/PySide2/Qt3DExtras') diff --git a/sources/pyside2/PySide2/Qt3DExtras/CMakeLists.txt b/sources/pyside2/PySide2/Qt3DExtras/CMakeLists.txt index 4bc25d52d..bd750949d 100644 --- a/sources/pyside2/PySide2/Qt3DExtras/CMakeLists.txt +++ b/sources/pyside2/PySide2/Qt3DExtras/CMakeLists.txt @@ -71,11 +71,10 @@ set(Qt3DExtras_libraries pyside2 set(Qt3DExtras_deps Qt3DRender) -create_pyside_module(Qt3DExtras - Qt3DExtras_include_dirs - Qt3DExtras_libraries - Qt3DExtras_deps - Qt3DExtras_SOURCE_DIR - Qt3DExtras_SRC - "" - ${Qt3DExtras_BINARY_DIR}/typesystem_3dextras.xml) +create_pyside_module(NAME Qt3DExtras + INCLUDE_DIRS Qt3DExtras_include_dirs + LIBRARIES Qt3DExtras_libraries + DEPS Qt3DExtras_deps + TYPESYSTEM_PATH Qt3DExtras_SOURCE_DIR + SOURCES Qt3DExtras_SRC + TYPESYSTEM_NAME ${Qt3DExtras_BINARY_DIR}/typesystem_3dextras.xml) -- cgit v1.2.3