From 4d82ee992992251bcadf0097a4df60fe7c3b7ef8 Mon Sep 17 00:00:00 2001 From: Alexandru Croitor Date: Wed, 28 Nov 2018 14:57:31 +0100 Subject: Make it hard to use the create_pyside_module function incorrectly Rewrite the function to use keyword arguments instead of ordered arguments. Also add error detection when required arguments are not passed, or have a typo in them. Adjust all the module cmake files to use keyword arguments. Change-Id: I7bb0c6561d7dca1e7f673e29eb457da50ae5df04 Reviewed-by: Qt CI Bot Reviewed-by: Cristian Maureira-Fredes --- sources/pyside2/PySide2/QtGui/CMakeLists.txt | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) (limited to 'sources/pyside2/PySide2/QtGui') diff --git a/sources/pyside2/PySide2/QtGui/CMakeLists.txt b/sources/pyside2/PySide2/QtGui/CMakeLists.txt index 38768ab0a..f514ea7c9 100644 --- a/sources/pyside2/PySide2/QtGui/CMakeLists.txt +++ b/sources/pyside2/PySide2/QtGui/CMakeLists.txt @@ -244,16 +244,15 @@ set(QtGui_libraries pyside2 ${Qt5Gui_LIBRARIES}) set(QtGui_deps QtCore) -create_pyside_module(QtGui - QtGui_include_dirs - QtGui_libraries - QtGui_deps - QtGui_SOURCE_DIR - QtGui_SRC - QPYTEXTOBJECT_MOC - ${QtGui_BINARY_DIR}/typesystem_gui.xml - QtGui_DROPPED_ENTRIES - "") +create_pyside_module(NAME QtGui + INCLUDE_DIRS QtGui_include_dirs + LIBRARIES QtGui_libraries + DEPS QtGui_deps + TYPESYSTEM_PATH QtGui_SOURCE_DIR + SOURCES QtGui_SRC + STATIC_SOURCES QPYTEXTOBJECT_MOC + TYPESYSTEM_NAME ${QtGui_BINARY_DIR}/typesystem_gui.xml + DROPPED_ENTRIES QtGui_DROPPED_ENTRIES) install(FILES ${pyside2_SOURCE_DIR}/qpytextobject.h DESTINATION include/PySide2/QtGui/) -- cgit v1.2.3