From 4d82ee992992251bcadf0097a4df60fe7c3b7ef8 Mon Sep 17 00:00:00 2001
From: Alexandru Croitor <alexandru.croitor@qt.io>
Date: Wed, 28 Nov 2018 14:57:31 +0100
Subject: Make it hard to use the create_pyside_module function incorrectly

Rewrite the function to use keyword arguments instead of ordered
arguments. Also add error detection when required arguments are not
passed, or have a typo in them.

Adjust all the module cmake files to use keyword arguments.

Change-Id: I7bb0c6561d7dca1e7f673e29eb457da50ae5df04
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
---
 sources/pyside2/PySide2/QtScript/CMakeLists.txt | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

(limited to 'sources/pyside2/PySide2/QtScript')

diff --git a/sources/pyside2/PySide2/QtScript/CMakeLists.txt b/sources/pyside2/PySide2/QtScript/CMakeLists.txt
index 08f5847b6..dfcb80789 100644
--- a/sources/pyside2/PySide2/QtScript/CMakeLists.txt
+++ b/sources/pyside2/PySide2/QtScript/CMakeLists.txt
@@ -37,13 +37,10 @@ set(QtScript_libraries      pyside2
                             ${Qt5Core_LIBRARIES}
                             ${Qt5Script_LIBRARIES})
 set(QtScript_deps QtCore)
-create_pyside_module(QtScript
-                     QtScript_include_dirs
-                     QtScript_libraries
-                     QtScript_deps
-                     QtScript_SOURCE_DIR
-                     QtScript_SRC
-                     ""
-                     ""
-                     ""
-                     QtScript_glue_sources)
+create_pyside_module(NAME QtScript
+                     INCLUDE_DIRS QtScript_include_dirs
+                     LIBRARIES QtScript_libraries
+                     DEPS QtScript_deps
+                     TYPESYSTEM_PATH QtScript_SOURCE_DIR
+                     SOURCES QtScript_SRC
+                     GLUE_SOURCES QtScript_glue_sources)
-- 
cgit v1.2.3