From 4d82ee992992251bcadf0097a4df60fe7c3b7ef8 Mon Sep 17 00:00:00 2001 From: Alexandru Croitor Date: Wed, 28 Nov 2018 14:57:31 +0100 Subject: Make it hard to use the create_pyside_module function incorrectly Rewrite the function to use keyword arguments instead of ordered arguments. Also add error detection when required arguments are not passed, or have a typo in them. Adjust all the module cmake files to use keyword arguments. Change-Id: I7bb0c6561d7dca1e7f673e29eb457da50ae5df04 Reviewed-by: Qt CI Bot Reviewed-by: Cristian Maureira-Fredes --- sources/pyside2/PySide2/QtWebEngine/CMakeLists.txt | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) (limited to 'sources/pyside2/PySide2/QtWebEngine') diff --git a/sources/pyside2/PySide2/QtWebEngine/CMakeLists.txt b/sources/pyside2/PySide2/QtWebEngine/CMakeLists.txt index 9029509ee..dc673ad06 100644 --- a/sources/pyside2/PySide2/QtWebEngine/CMakeLists.txt +++ b/sources/pyside2/PySide2/QtWebEngine/CMakeLists.txt @@ -22,11 +22,10 @@ set(QtWebEngine_libraries pyside2 ${Qt5Core_LIBRARIES} ) set(QtWebEngine_deps QtCore) -create_pyside_module(QtWebEngine - QtWebEngine_include_dirs - QtWebEngine_libraries - QtWebEngine_deps - QtWebEngine_SOURCE_DIR - QtWebEngine_SRC - "") +create_pyside_module(NAME QtWebEngine + INCLUDE_DIRS QtWebEngine_include_dirs + LIBRARIES QtWebEngine_libraries + DEPS QtWebEngine_deps + TYPESYSTEM_PATH QtWebEngine_SOURCE_DIR + SOURCES QtWebEngine_SRC) -- cgit v1.2.3