From 4d82ee992992251bcadf0097a4df60fe7c3b7ef8 Mon Sep 17 00:00:00 2001 From: Alexandru Croitor Date: Wed, 28 Nov 2018 14:57:31 +0100 Subject: Make it hard to use the create_pyside_module function incorrectly Rewrite the function to use keyword arguments instead of ordered arguments. Also add error detection when required arguments are not passed, or have a typo in them. Adjust all the module cmake files to use keyword arguments. Change-Id: I7bb0c6561d7dca1e7f673e29eb457da50ae5df04 Reviewed-by: Qt CI Bot Reviewed-by: Cristian Maureira-Fredes --- sources/pyside2/PySide2/QtWebKitWidgets/CMakeLists.txt | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) (limited to 'sources/pyside2/PySide2/QtWebKitWidgets') diff --git a/sources/pyside2/PySide2/QtWebKitWidgets/CMakeLists.txt b/sources/pyside2/PySide2/QtWebKitWidgets/CMakeLists.txt index cd7aa32dd..7422a05da 100644 --- a/sources/pyside2/PySide2/QtWebKitWidgets/CMakeLists.txt +++ b/sources/pyside2/PySide2/QtWebKitWidgets/CMakeLists.txt @@ -60,11 +60,10 @@ set(QtWebKitWidgets_libraries pyside2 ${Qt5Core_LIBRARIES} ) set(QtWebKitWidgets_deps QtWidgets QtPrintSupport QtNetwork) -create_pyside_module(QtWebKitWidgets - QtWebKitWidgets_include_dirs - QtWebKitWidgets_libraries - QtWebKitWidgets_deps - QtWebKitWidgets_SOURCE_DIR - QtWebKitWidgets_SRC - "") +create_pyside_module(NAME QtWebKitWidgets + INCLUDE_DIRS QtWebKitWidgets_include_dirs + LIBRARIES QtWebKitWidgets_libraries + DEPS QtWebKitWidgets_deps + TYPESYSTEM_PATH QtWebKitWidgets_SOURCE_DIR + SOURCES QtWebKitWidgets_SRC) -- cgit v1.2.3