From 4d82ee992992251bcadf0097a4df60fe7c3b7ef8 Mon Sep 17 00:00:00 2001 From: Alexandru Croitor Date: Wed, 28 Nov 2018 14:57:31 +0100 Subject: Make it hard to use the create_pyside_module function incorrectly Rewrite the function to use keyword arguments instead of ordered arguments. Also add error detection when required arguments are not passed, or have a typo in them. Adjust all the module cmake files to use keyword arguments. Change-Id: I7bb0c6561d7dca1e7f673e29eb457da50ae5df04 Reviewed-by: Qt CI Bot Reviewed-by: Cristian Maureira-Fredes --- sources/pyside2/PySide2/QtWidgets/CMakeLists.txt | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) (limited to 'sources/pyside2/PySide2/QtWidgets/CMakeLists.txt') diff --git a/sources/pyside2/PySide2/QtWidgets/CMakeLists.txt b/sources/pyside2/PySide2/QtWidgets/CMakeLists.txt index 5f10d5988..4267c1160 100644 --- a/sources/pyside2/PySide2/QtWidgets/CMakeLists.txt +++ b/sources/pyside2/PySide2/QtWidgets/CMakeLists.txt @@ -231,13 +231,10 @@ set(QtWidgets_libraries pyside2 ) set(QtWidgets_deps QtGui) -create_pyside_module(QtWidgets - QtWidgets_include_dirs - QtWidgets_libraries - QtWidgets_deps - QtWidgets_SOURCE_DIR - QtWidgets_SRC - "" - ${QtWidgets_BINARY_DIR}/typesystem_widgets.xml - "" - "") +create_pyside_module(NAME QtWidgets + INCLUDE_DIRS QtWidgets_include_dirs + LIBRARIES QtWidgets_libraries + DEPS QtWidgets_deps + TYPESYSTEM_PATH QtWidgets_SOURCE_DIR + SOURCES QtWidgets_SRC + TYPESYSTEM_NAME ${QtWidgets_BINARY_DIR}/typesystem_widgets.xml) -- cgit v1.2.3