From f2063ee4737f90c5d412a9a328672fde32b033eb Mon Sep 17 00:00:00 2001 From: Friedemann Kleint Date: Thu, 2 Nov 2017 14:18:03 +0100 Subject: PySide2: Simplify typesystem path handling Modify the typesystem.xml files such that all dependent files are loaded via module (for example, QtCore/typesystem_core.xml). As a result, it is no longer necessary to add each dependent directory to the typesystem path; it is sufficient to pass the binary and source path of PySide2 and the source directory of the Qt module only. This requires rewriting the dependency checking for --reuse-build so that it loops over the source directories of the dependent Qt modules. Change-Id: Ib234c2673f4ee93cc8a3282fac69bcfcfaebd0ac Reviewed-by: Alexandru Croitor --- sources/pyside2/PySide2/QtCharts/CMakeLists.txt | 11 +---------- sources/pyside2/PySide2/QtCharts/typesystem_charts.xml | 2 +- sources/pyside2/PySide2/QtConcurrent/CMakeLists.txt | 6 +----- .../pyside2/PySide2/QtConcurrent/typesystem_concurrent.xml | 2 +- sources/pyside2/PySide2/QtCore/CMakeLists.txt | 5 +---- sources/pyside2/PySide2/QtCore/typesystem_core.xml.in | 4 ++-- sources/pyside2/PySide2/QtDataVisualization/CMakeLists.txt | 9 +-------- .../QtDataVisualization/typesystem_datavisualization.xml | 2 +- sources/pyside2/PySide2/QtGui/CMakeLists.txt | 5 +---- sources/pyside2/PySide2/QtGui/typesystem_gui.xml.in | 6 +++--- sources/pyside2/PySide2/QtGui/typesystem_gui_common.xml | 2 +- sources/pyside2/PySide2/QtHelp/CMakeLists.txt | 6 +----- sources/pyside2/PySide2/QtHelp/typesystem_help.xml | 2 +- sources/pyside2/PySide2/QtMacExtras/CMakeLists.txt | 8 +------- sources/pyside2/PySide2/QtMacExtras/typesystem_macextras.xml | 4 ++-- sources/pyside2/PySide2/QtMultimedia/CMakeLists.txt | 6 +----- .../pyside2/PySide2/QtMultimedia/typesystem_multimedia.xml | 4 ++-- .../PySide2/QtMultimedia/typesystem_multimedia_common.xml | 6 +++--- sources/pyside2/PySide2/QtMultimediaWidgets/CMakeLists.txt | 7 +------ .../QtMultimediaWidgets/typesystem_multimediawidgets.xml | 8 ++++---- sources/pyside2/PySide2/QtNetwork/CMakeLists.txt | 6 +----- sources/pyside2/PySide2/QtNetwork/typesystem_network.xml | 2 +- sources/pyside2/PySide2/QtOpenGL/CMakeLists.txt | 6 +----- sources/pyside2/PySide2/QtOpenGL/typesystem_opengl.xml | 2 +- sources/pyside2/PySide2/QtPrintSupport/CMakeLists.txt | 6 +----- .../PySide2/QtPrintSupport/typesystem_printsupport.xml | 2 +- sources/pyside2/PySide2/QtQml/CMakeLists.txt | 6 +----- sources/pyside2/PySide2/QtQml/typesystem_qml.xml | 6 +++--- sources/pyside2/PySide2/QtQuick/CMakeLists.txt | 9 +-------- sources/pyside2/PySide2/QtQuick/typesystem_quick.xml | 8 ++++---- sources/pyside2/PySide2/QtQuickWidgets/CMakeLists.txt | 8 +------- .../PySide2/QtQuickWidgets/typesystem_quickwidgets.xml | 12 ++++++------ sources/pyside2/PySide2/QtScript/CMakeLists.txt | 4 +--- sources/pyside2/PySide2/QtScript/typesystem_script.xml | 2 +- sources/pyside2/PySide2/QtScriptTools/CMakeLists.txt | 7 +------ .../pyside2/PySide2/QtScriptTools/typesystem_scripttools.xml | 6 +++--- sources/pyside2/PySide2/QtSql/CMakeLists.txt | 6 +----- sources/pyside2/PySide2/QtSql/typesystem_sql.xml | 2 +- sources/pyside2/PySide2/QtSvg/CMakeLists.txt | 6 +----- sources/pyside2/PySide2/QtSvg/typesystem_svg.xml | 2 +- sources/pyside2/PySide2/QtTest/CMakeLists.txt | 6 +----- sources/pyside2/PySide2/QtTest/typesystem_test.xml | 6 +++--- sources/pyside2/PySide2/QtTextToSpeech/CMakeLists.txt | 7 +------ .../PySide2/QtTextToSpeech/typesystem_texttospeech.xml | 2 +- sources/pyside2/PySide2/QtUiTools/CMakeLists.txt | 7 +------ sources/pyside2/PySide2/QtUiTools/typesystem_uitools.xml | 4 ++-- sources/pyside2/PySide2/QtWebChannel/CMakeLists.txt | 4 +--- .../pyside2/PySide2/QtWebChannel/typesystem_webchannel.xml | 2 +- sources/pyside2/PySide2/QtWebEngineWidgets/CMakeLists.txt | 9 +-------- .../QtWebEngineWidgets/typesystem_webenginewidgets.xml | 10 +++++----- sources/pyside2/PySide2/QtWebKit/CMakeLists.txt | 6 +----- sources/pyside2/PySide2/QtWebKit/typesystem_webkit.xml | 6 +++--- sources/pyside2/PySide2/QtWebKitWidgets/CMakeLists.txt | 9 +-------- .../PySide2/QtWebKitWidgets/typesystem_webkitwidgets.xml | 10 +++++----- sources/pyside2/PySide2/QtWebSockets/CMakeLists.txt | 5 +---- .../pyside2/PySide2/QtWebSockets/typesystem_websockets.xml | 4 ++-- sources/pyside2/PySide2/QtWidgets/CMakeLists.txt | 6 +----- sources/pyside2/PySide2/QtWidgets/typesystem_widgets.xml.in | 6 +++--- .../pyside2/PySide2/QtWidgets/typesystem_widgets_common.xml | 2 +- sources/pyside2/PySide2/QtWinExtras/CMakeLists.txt | 8 +------- sources/pyside2/PySide2/QtWinExtras/typesystem_winextras.xml | 4 ++-- sources/pyside2/PySide2/QtX11Extras/CMakeLists.txt | 8 +------- sources/pyside2/PySide2/QtX11Extras/typesystem_x11extras.xml | 2 +- sources/pyside2/PySide2/QtXml/CMakeLists.txt | 5 +---- sources/pyside2/PySide2/QtXml/typesystem_xml.xml | 2 +- sources/pyside2/PySide2/QtXmlPatterns/CMakeLists.txt | 5 +---- .../pyside2/PySide2/QtXmlPatterns/typesystem_xmlpatterns.xml | 2 +- 67 files changed, 106 insertions(+), 254 deletions(-) (limited to 'sources/pyside2/PySide2') diff --git a/sources/pyside2/PySide2/QtCharts/CMakeLists.txt b/sources/pyside2/PySide2/QtCharts/CMakeLists.txt index 5d6ed6aaf..fa177300d 100644 --- a/sources/pyside2/PySide2/QtCharts/CMakeLists.txt +++ b/sources/pyside2/PySide2/QtCharts/CMakeLists.txt @@ -58,15 +58,6 @@ ${QtCharts_GEN_DIR}/qtcharts_wrapper.cpp ${QtCharts_GEN_DIR}/qtcharts_module_wrapper.cpp ) -make_path(QtCharts_typesystem_path - ${QtCore_SOURCE_DIR} - ${QtCore_BINARY_DIR} - ${QtGui_SOURCE_DIR} - ${QtGui_BINARY_DIR} - ${QtWidgets_SOURCE_DIR} - ${QtWidgets_BINARY_DIR} - ${QtCharts_SOURCE_DIR}) - set(QtCharts_include_dirs ${QtCharts_SOURCE_DIR} ${QtCharts_BINARY_DIR} ${Qt5Core_INCLUDE_DIRS} @@ -94,6 +85,6 @@ create_pyside_module(QtCharts QtCharts_include_dirs QtCharts_libraries QtCharts_deps - QtCharts_typesystem_path + QtCharts_SOURCE_DIR QtCharts_SRC "") diff --git a/sources/pyside2/PySide2/QtCharts/typesystem_charts.xml b/sources/pyside2/PySide2/QtCharts/typesystem_charts.xml index 6c0c02a47..ca7646421 100644 --- a/sources/pyside2/PySide2/QtCharts/typesystem_charts.xml +++ b/sources/pyside2/PySide2/QtCharts/typesystem_charts.xml @@ -40,7 +40,7 @@ ****************************************************************************/ --> - + diff --git a/sources/pyside2/PySide2/QtConcurrent/CMakeLists.txt b/sources/pyside2/PySide2/QtConcurrent/CMakeLists.txt index 4a7fd53ff..4fb62ee99 100644 --- a/sources/pyside2/PySide2/QtConcurrent/CMakeLists.txt +++ b/sources/pyside2/PySide2/QtConcurrent/CMakeLists.txt @@ -6,10 +6,6 @@ ${QtConcurrent_GEN_DIR}/qtconcurrent_wrapper.cpp ${QtConcurrent_GEN_DIR}/qtconcurrent_module_wrapper.cpp ) -make_path(QtConcurrent_typesystem_path ${QtCore_SOURCE_DIR} - ${QtCore_BINARY_DIR} - ${QtConcurrent_SOURCE_DIR}) - set(QtConcurrent_include_dirs ${QtConcurrent_SOURCE_DIR} ${QtConcurrent_BINARY_DIR} ${Qt5Core_INCLUDE_DIRS} @@ -30,6 +26,6 @@ create_pyside_module(QtConcurrent QtConcurrent_include_dirs QtConcurrent_libraries QtConcurrent_deps - QtConcurrent_typesystem_path + QtConcurrent_SOURCE_DIR QtConcurrent_SRC "") diff --git a/sources/pyside2/PySide2/QtConcurrent/typesystem_concurrent.xml b/sources/pyside2/PySide2/QtConcurrent/typesystem_concurrent.xml index 692e744a1..09f590914 100644 --- a/sources/pyside2/PySide2/QtConcurrent/typesystem_concurrent.xml +++ b/sources/pyside2/PySide2/QtConcurrent/typesystem_concurrent.xml @@ -40,7 +40,7 @@ ****************************************************************************/ --> - + diff --git a/sources/pyside2/PySide2/QtCore/CMakeLists.txt b/sources/pyside2/PySide2/QtCore/CMakeLists.txt index 384243f7c..dd2e212b0 100644 --- a/sources/pyside2/PySide2/QtCore/CMakeLists.txt +++ b/sources/pyside2/PySide2/QtCore/CMakeLists.txt @@ -164,9 +164,6 @@ ${QtCore_GEN_DIR}/qtcore_module_wrapper.cpp configure_file("${QtCore_SOURCE_DIR}/typesystem_core.xml.in" "${QtCore_BINARY_DIR}/typesystem_core.xml" @ONLY) -make_path(QtCore_typesystem_path ${QtCore_SOURCE_DIR}) - - set(QtCore_include_dirs ${QtCore_SOURCE_DIR} ${QtCore_BINARY_DIR} ${Qt5Core_INCLUDE_DIRS} @@ -183,7 +180,7 @@ create_pyside_module(QtCore QtCore_include_dirs QtCore_libraries "" - QtCore_typesystem_path + QtCore_SOURCE_DIR QtCore_SRC QtCore_gluecode ${QtCore_BINARY_DIR}/typesystem_core.xml) diff --git a/sources/pyside2/PySide2/QtCore/typesystem_core.xml.in b/sources/pyside2/PySide2/QtCore/typesystem_core.xml.in index 4ccf6423f..58caaee55 100644 --- a/sources/pyside2/PySide2/QtCore/typesystem_core.xml.in +++ b/sources/pyside2/PySide2/QtCore/typesystem_core.xml.in @@ -40,6 +40,6 @@ ****************************************************************************/ --> - - + + diff --git a/sources/pyside2/PySide2/QtDataVisualization/CMakeLists.txt b/sources/pyside2/PySide2/QtDataVisualization/CMakeLists.txt index 54809807c..e61a70234 100644 --- a/sources/pyside2/PySide2/QtDataVisualization/CMakeLists.txt +++ b/sources/pyside2/PySide2/QtDataVisualization/CMakeLists.txt @@ -41,13 +41,6 @@ ${QtDataVisualization_GEN_DIR}/qtdatavisualization_wrapper.cpp ${QtDataVisualization_GEN_DIR}/qtdatavisualization_module_wrapper.cpp ) -make_path(QtDataVisualization_typesystem_path - ${QtCore_SOURCE_DIR} - ${QtCore_BINARY_DIR} - ${QtGui_SOURCE_DIR} - ${QtGui_BINARY_DIR} - ${QtDataVisualization_SOURCE_DIR}) - set(QtDataVisualization_include_dirs ${QtDataVisualization_SOURCE_DIR} ${QtDataVisualization_BINARY_DIR} ${Qt5Core_INCLUDE_DIRS} @@ -72,6 +65,6 @@ create_pyside_module(QtDataVisualization QtDataVisualization_include_dirs QtDataVisualization_libraries QtDataVisualization_deps - QtDataVisualization_typesystem_path + QtDataVisualization_SOURCE_DIR QtDataVisualization_SRC "") diff --git a/sources/pyside2/PySide2/QtDataVisualization/typesystem_datavisualization.xml b/sources/pyside2/PySide2/QtDataVisualization/typesystem_datavisualization.xml index bc2d66df4..6b628c9bf 100644 --- a/sources/pyside2/PySide2/QtDataVisualization/typesystem_datavisualization.xml +++ b/sources/pyside2/PySide2/QtDataVisualization/typesystem_datavisualization.xml @@ -74,7 +74,7 @@ result.append(row); } - + diff --git a/sources/pyside2/PySide2/QtGui/CMakeLists.txt b/sources/pyside2/PySide2/QtGui/CMakeLists.txt index b0973debe..b21120115 100644 --- a/sources/pyside2/PySide2/QtGui/CMakeLists.txt +++ b/sources/pyside2/PySide2/QtGui/CMakeLists.txt @@ -192,9 +192,6 @@ ${QtGui_GEN_DIR}/qtgui_module_wrapper.cpp configure_file("${QtGui_SOURCE_DIR}/typesystem_gui.xml.in" "${QtGui_BINARY_DIR}/typesystem_gui.xml" @ONLY) -make_path(QtGui_typesystem_path ${QtCore_SOURCE_DIR} ${QtCore_BINARY_DIR} - ${QtGui_SOURCE_DIR}) - set(QtGui_include_dirs ${QtGui_SOURCE_DIR} ${QtGui_BINARY_DIR} ${pyside2_SOURCE_DIR} @@ -215,7 +212,7 @@ create_pyside_module(QtGui QtGui_include_dirs QtGui_libraries QtGui_deps - QtGui_typesystem_path + QtGui_SOURCE_DIR QtGui_SRC QPYTEXTOBJECT_MOC ${QtGui_BINARY_DIR}/typesystem_gui.xml) diff --git a/sources/pyside2/PySide2/QtGui/typesystem_gui.xml.in b/sources/pyside2/PySide2/QtGui/typesystem_gui.xml.in index 0de65876a..ee909875e 100644 --- a/sources/pyside2/PySide2/QtGui/typesystem_gui.xml.in +++ b/sources/pyside2/PySide2/QtGui/typesystem_gui.xml.in @@ -40,7 +40,7 @@ ****************************************************************************/ --> - - - + + + diff --git a/sources/pyside2/PySide2/QtGui/typesystem_gui_common.xml b/sources/pyside2/PySide2/QtGui/typesystem_gui_common.xml index 9260b3d38..b316d90ad 100644 --- a/sources/pyside2/PySide2/QtGui/typesystem_gui_common.xml +++ b/sources/pyside2/PySide2/QtGui/typesystem_gui_common.xml @@ -40,7 +40,7 @@ ****************************************************************************/ --> - +