From 2827dca2c076d03e8ea46be562e455bd286ad21a Mon Sep 17 00:00:00 2001 From: Friedemann Kleint Date: Thu, 2 May 2019 11:16:50 +0200 Subject: libpyside: Refactor code building the signature The function slotCall() used the now deprecated function QString::sprintf(). Rewrite the code using QByteArray since converting to QString and back is wasteful for the purpose. Change-Id: Ifcd50e76bb7ea0c9d2f2e7453c6e265abe6265b7 Reviewed-by: Christian Tismer --- sources/pyside2/libpyside/pysideslot.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'sources/pyside2/libpyside/pysideslot.cpp') diff --git a/sources/pyside2/libpyside/pysideslot.cpp b/sources/pyside2/libpyside/pysideslot.cpp index 6f6658cf8..694b5b59f 100644 --- a/sources/pyside2/libpyside/pysideslot.cpp +++ b/sources/pyside2/libpyside/pysideslot.cpp @@ -147,10 +147,10 @@ PyObject *slotCall(PyObject *self, PyObject *args, PyObject * /* kw */) data->slotName = strdup(Shiboken::String::toCString(funcName)); } - - QByteArray returnType = QMetaObject::normalizedType(data->resultType); - QByteArray signature = QString().sprintf("%s(%s)", data->slotName, data->args).toUtf8(); - signature = returnType + " " + signature; + const QByteArray returnType = QMetaObject::normalizedType(data->resultType); + const QByteArray signature = + returnType + ' ' + const_cast(data->slotName) + + '(' + const_cast(data->args) + ')'; if (!pySlotName) pySlotName = Shiboken::String::fromCString(PYSIDE_SLOT_LIST_ATTR); -- cgit v1.2.3