From ee8e7117c79f6820cb228e0f0da522ce7d3c1dce Mon Sep 17 00:00:00 2001 From: Boxiang Sun Date: Sun, 20 May 2018 11:04:45 +0800 Subject: Improve the QByteArray implementation The available constructors for QByteArray are now: bytes, bytearray, and QByteArray, unicode is not accepted anymore. Also the concatenation is now possible between QByteArrays. Even though is not possible to initialize a QByteArray with an unicode, we include the possibility to compare it with one (Compatibility with PyQt). The __repr__ and __str__ are now properly working. There seemed to be a confusion regarding data types between Shiboken, Python2 and Python3 related to bytes, so now the structure is based on the flag SBK_BYTES_NAME, which is define as "bytes" for Python3 and "str" for Python2. Many tests were modified to properly handle string, using the `py3kcompat` module. Task-number: PYSIDE-232 Change-Id: I8b671f367c60a0870c72dcbe5662106b3225037d Reviewed-by: Alexandru Croitor --- sources/pyside2/tests/QtNetwork/bug_446.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'sources/pyside2/tests/QtNetwork/bug_446.py') diff --git a/sources/pyside2/tests/QtNetwork/bug_446.py b/sources/pyside2/tests/QtNetwork/bug_446.py index da4e27d42..4fcda65b7 100644 --- a/sources/pyside2/tests/QtNetwork/bug_446.py +++ b/sources/pyside2/tests/QtNetwork/bug_446.py @@ -32,10 +32,11 @@ from PySide2.QtCore import * from PySide2.QtNetwork import * from helper import UsesQCoreApplication +import py3kcompat as py3k class HttpSignalsCase(UsesQCoreApplication): '''Test case for launching QHttp signals''' - DATA = "PySide rocks" + DATA = py3k.b("PySide rocks") def onError(self): self.assertTrue(False) @@ -48,7 +49,7 @@ class HttpSignalsCase(UsesQCoreApplication): def onReadReady(self): data = self.client.read(100) - self.assertEqual(data.size(), len(HttpSignalsCase.DATA)) + self.assertEqual(len(data), len(HttpSignalsCase.DATA)) self.assertEqual(data, HttpSignalsCase.DATA) self.done() -- cgit v1.2.3