From 78b2438037504ae80eaf6b01d49df9ddb660656a Mon Sep 17 00:00:00 2001
From: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Date: Mon, 18 Feb 2019 16:37:37 +0100
Subject: Set proper parent when overloading QUiLoader

In a couple of methods of QUiLoader, we had a parent
override leaving the methods without the proper parent.

    setParent(pyArgs[0], pyResult) # Correct
    setParent(self, pyResult) # Wrong override

Defining the ownership to the target class corrects this
issue and just leaves the "Correct" approach.

Fixes: PYSIDE-938
Change-Id: Id20d74756e14c58caba2ab4c65484d15da88df16
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
---
 sources/pyside2/PySide2/QtUiTools/typesystem_uitools.xml | 3 +++
 1 file changed, 3 insertions(+)

(limited to 'sources/pyside2')

diff --git a/sources/pyside2/PySide2/QtUiTools/typesystem_uitools.xml b/sources/pyside2/PySide2/QtUiTools/typesystem_uitools.xml
index 8086da01e..2cbe490aa 100644
--- a/sources/pyside2/PySide2/QtUiTools/typesystem_uitools.xml
+++ b/sources/pyside2/PySide2/QtUiTools/typesystem_uitools.xml
@@ -90,18 +90,21 @@
       <modify-function signature="createAction(QObject*,const QString&amp;)">
         <modify-argument index="return">
           <parent index="1" action="add"/>
+          <define-ownership class="target" owner="default"/>
         </modify-argument>
       </modify-function>
 
       <modify-function signature="createActionGroup(QObject*,const QString&amp;)">
         <modify-argument index="return">
           <parent index="1" action="add"/>
+          <define-ownership class="target" owner="default"/>
         </modify-argument>
       </modify-function>
 
       <modify-function signature="createLayout(const QString&amp;,QObject*,const QString&amp;)">
         <modify-argument index="return">
           <parent index="2" action="add"/>
+          <define-ownership class="target" owner="default"/>
         </modify-argument>
       </modify-function>
 
-- 
cgit v1.2.3