From 2cc7ded80caa506263ba2c9fd87db76dae71956a Mon Sep 17 00:00:00 2001 From: Friedemann Kleint Date: Mon, 18 Sep 2023 09:55:49 +0200 Subject: Fix namespaces - Use nested namespaces instead repetitive namespace declaration - Remove anonymous namespaces that contain only static functions. "static" is sufficient here, the anonymous namespace only increases compilation time. Pick-to: 6.6 6.5 Change-Id: I6cd1b63da79eaf40a1b7ae031def97fa22903e99 Reviewed-by: Shyamnath Premnadh --- sources/pyside6/libpyside/pysidesignal.cpp | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) (limited to 'sources/pyside6/libpyside/pysidesignal.cpp') diff --git a/sources/pyside6/libpyside/pysidesignal.cpp b/sources/pyside6/libpyside/pysidesignal.cpp index 90c1a3ff1..9172a0c45 100644 --- a/sources/pyside6/libpyside/pysidesignal.cpp +++ b/sources/pyside6/libpyside/pysidesignal.cpp @@ -100,8 +100,7 @@ static std::optional parseArgumentNames(PyObject *argArguments) return result; } -namespace PySide { -namespace Signal { +namespace PySide::Signal { //aux class SignalSignature { public: @@ -121,8 +120,7 @@ namespace Signal { static void instanceInitialize(PySideSignalInstance *, PyObject *, PySideSignal *, PyObject *, int); static QByteArray parseSignature(PyObject *); static PyObject *buildQtCompatible(const QByteArray &); -} -} +} // PySide::Signal extern "C" { @@ -827,8 +825,7 @@ static PyObject *metaSignalCheck(PyObject * /* klass */, PyObject *arg) } // extern "C" -namespace PySide { -namespace Signal { +namespace PySide::Signal { static const char *MetaSignal_SignatureStrings[] = { "PySide6.QtCore.MetaSignal.__instancecheck__(self,object:object)->bool", @@ -1335,6 +1332,4 @@ QByteArray voidType() return QByteArrayLiteral("void"); } -} //namespace Signal -} //namespace PySide - +} //namespace PySide::Signal -- cgit v1.2.3