From e39a383766aa1c73e94d948d6e3a3bd20729f19b Mon Sep 17 00:00:00 2001 From: Friedemann Kleint Date: Mon, 28 Aug 2023 15:20:30 +0200 Subject: libpyside: Use a static string for the slot attribute attached to methods Task-number: PYSIDE-748 Change-Id: Ieeeb2c1c392706a5c74bf29ff67ff4ddd8c4feaa Reviewed-by: Shyamnath Premnadh --- sources/pyside6/libpyside/pysideslot.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'sources/pyside6/libpyside/pysideslot.cpp') diff --git a/sources/pyside6/libpyside/pysideslot.cpp b/sources/pyside6/libpyside/pysideslot.cpp index 9b0f1f4e0..32f629ade 100644 --- a/sources/pyside6/libpyside/pysideslot.cpp +++ b/sources/pyside6/libpyside/pysideslot.cpp @@ -3,6 +3,7 @@ #include "pysidesignal_p.h" #include "pysideslot_p.h" +#include "pysidestaticstrings.h" #include @@ -95,7 +96,6 @@ int slotTpInit(PyObject *self, PyObject *args, PyObject *kw) PyObject *slotCall(PyObject *self, PyObject *args, PyObject * /* kw */) { - static PyObject *pySlotName = nullptr; PyObject *callback = nullptr; if (!PyArg_UnpackTuple(args, "Slot.__call__", 1, 1, &callback)) @@ -117,11 +117,9 @@ PyObject *slotCall(PyObject *self, PyObject *args, PyObject * /* kw */) const QByteArray signature = returnType + ' ' + data->slotData->name + '(' + data->slotData->args + ')'; - if (!pySlotName) - pySlotName = String::fromCString(PYSIDE_SLOT_LIST_ATTR); - PyObject *pySignature = String::fromCString(signature); PyObject *signatureList = nullptr; + PyObject *pySlotName = PySide::PySideMagicName::slot_list_attr(); if (PyObject_HasAttr(callback, pySlotName)) { signatureList = PyObject_GetAttr(callback, pySlotName); } else { -- cgit v1.2.3