diff options
| author | Christian Tismer <ctismer@gmail.com> | 2015-12-28 01:04:46 +0100 |
|---|---|---|
| committer | Christian Tismer <ctismer@gmail.com> | 2015-12-28 01:04:46 +0100 |
| commit | 50018546c75d030895cb12a57cdf0dc86d3d5978 (patch) | |
| tree | 914ce3ca4e1640d70b4757e7b0416af2fd0002d1 | |
| parent | c4d38ce56be5cdd61b34e116423805846f7717eb (diff) | |
add a comment why in this case using cmake's sorcery is superior than explicit paths
| -rw-r--r-- | shibokenmodule/CMakeLists.txt | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/shibokenmodule/CMakeLists.txt b/shibokenmodule/CMakeLists.txt index 0c12c85..7e90b51 100644 --- a/shibokenmodule/CMakeLists.txt +++ b/shibokenmodule/CMakeLists.txt @@ -9,6 +9,9 @@ ${CMAKE_CURRENT_BINARY_DIR}/shiboken2/shiboken2_module_wrapper.cpp ) add_custom_command(OUTPUT ${sample_SRC} +# Note: shiboken2 is an executable target. By not specifying its explicit +# path, CMAKE figures it out, itself! +# This fixes an issue with Visual Studio, see https://github.com/PySide/shiboken2/pull/11 COMMAND shiboken2 --project-file=${CMAKE_CURRENT_BINARY_DIR}/shibokenmodule.txt ${GENERATOR_EXTRA_FLAGS} WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} COMMENT "Running generator for 'shiboken2'..." |