aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIvan Komissarov <ABBAPOH@gmail.com>2019-02-19 19:34:47 +0100
committerIvan Komissarov <ABBAPOH@gmail.com>2019-02-20 11:47:42 +0000
commit87ba49576d7ab713fa0ac1f74571f43aa19620fe (patch)
tree03ceabb1eb50a87850d466e8fcbd181b43a0079f
parent07e82d9b91f3fa52590db2849aef6d5b0062c3a9 (diff)
Fix allocating temp QString on each iteration
Fixes -Wloop-range-analysis Change-Id: I16b1852aa357fb7aeb09d29e3cb6106cad0adf7b Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
-rw-r--r--src/app/qbs-setup-toolchains/probe.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/app/qbs-setup-toolchains/probe.cpp b/src/app/qbs-setup-toolchains/probe.cpp
index 1f43014d3..390b539a4 100644
--- a/src/app/qbs-setup-toolchains/probe.cpp
+++ b/src/app/qbs-setup-toolchains/probe.cpp
@@ -138,7 +138,7 @@ static QStringList toolchainTypeFromCompilerName(const QString &compilerName)
return canonicalToolchain(QLatin1String("msvc"));
const auto types = { QLatin1String("clang"), QLatin1String("llvm"),
QLatin1String("mingw"), QLatin1String("gcc") };
- for (const QString &type : types) {
+ for (const auto &type : types) {
if (compilerName.contains(type))
return canonicalToolchain(type);
}