Do not insert into module property cache if caching is disabled.

The current code does not seem to result in observable issues, but it
can't possibly be right to retrieve a value from the cache that was
inserted while caching was off.

Change-Id: I6db84652014b155f93056e48d52915c846892560
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

1 files changed, 2 insertions, 1 deletions

diff --git a/src/lib/corelib/jsextensions/moduleproperties.cpp b/src/lib/corelib/jsextensions/moduleproperties.cpp
index bed72ee55..5780ad401 100644
--- a/src/lib/corelib/jsextensions/moduleproperties.cpp
+++ b/src/lib/corelib/jsextensions/moduleproperties.cpp
@@ -142,7 +142,8 @@ QScriptValue ModuleProperties::moduleProperties(QScriptContext *context, QScript
 
         // Cache the variant value. We must not cache the QScriptValue here, because it's a
         // reference and the user might change the actual object.
-        qbsEngine->addToPropertyCache(moduleName, propertyName, oneValue, properties, value);
+        if (qbsEngine->isPropertyCacheEnabled())
+            qbsEngine->addToPropertyCache(moduleName, propertyName, oneValue, properties, value);
     }
     return engine->toScriptValue(value);
 }