Check for self-assignment in ProjectData assignment operator.

Should not omit this in dealing with dynamic memory.

Change-Id: Ifc1e70a353446ab61023b9224a23285febfa6b97
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>

1 files changed, 4 insertions, 2 deletions

diff --git a/src/lib/corelib/api/projectdata.cpp b/src/lib/corelib/api/projectdata.cpp
index afc4d50a9..12cdeda9c 100644
--- a/src/lib/corelib/api/projectdata.cpp
+++ b/src/lib/corelib/api/projectdata.cpp
@@ -737,8 +737,10 @@ PropertyMap::~PropertyMap()
 
 PropertyMap &PropertyMap::operator =(const PropertyMap &other)
 {
-    delete d;
-    d = new Internal::PropertyMapPrivate(*other.d);
+    if (this != &other) {
+        delete d;
+        d = new Internal::PropertyMapPrivate(*other.d);
+    }
     return *this;
 }