diff options
author | Jake Petroules <jake.petroules@qt.io> | 2016-12-08 13:12:23 -0800 |
---|---|---|
committer | Jake Petroules <jake.petroules@qt.io> | 2016-12-09 19:22:19 +0000 |
commit | 3c579832ac6f82c6b6c61f6fc5400fa3fcb7ef33 (patch) | |
tree | 92795e642c643a5a9ccc02154f0f5765b9bbe12a | |
parent | 574d4ef812f9dcbb54ce659d2c6f247be773d0de (diff) |
Turn process execution errors in GccProbe into fatal errors
There is absolutely no point continuining from here, and ignoring errors
from executing the compiler will simply result in a more cryptic error
message for the user.
For example, the bug fixed by the previous patch set resulting in an
"unknown arch armv7" error message from Clang was actually displayed as
missing compiler version properties, seemingly unrelated.
Change-Id: I7ddf4a8f7b82a71355065074aae5401e7292bae1
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
-rw-r--r-- | share/qbs/modules/cpp/gcc.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/share/qbs/modules/cpp/gcc.js b/share/qbs/modules/cpp/gcc.js index fed290b15..dda94ebb7 100644 --- a/share/qbs/modules/cpp/gcc.js +++ b/share/qbs/modules/cpp/gcc.js @@ -945,7 +945,7 @@ function dumpMacros(compilerFilePath, args, nullDevice) { var p = new Process(); try { p.setEnv("LC_ALL", "C"); - p.exec(compilerFilePath, (args || []).concat(["-dM", "-E", "-x", "c", nullDevice])); + p.exec(compilerFilePath, (args || []).concat(["-dM", "-E", "-x", "c", nullDevice]), true); var map = {}; p.readStdOut().trim().split("\n").map(function (line) { var parts = line.split(" ", 3); @@ -969,7 +969,7 @@ function dumpDefaultPaths(compilerFilePath, args, nullDevice, pathListSeparator, else args.push("--sysroot=" + sysroot); } - p.exec(compilerFilePath, args.concat(["-v", "-E", "-x", "c++", nullDevice])); + p.exec(compilerFilePath, args.concat(["-v", "-E", "-x", "c++", nullDevice]), true); var suffix = " (framework directory)"; var includePaths = []; var libraryPaths = []; |