diff options
| author | Ivan Komissarov <abbapoh@gmail.com> | 2020-04-04 21:47:50 +0200 |
|---|---|---|
| committer | Ivan Komissarov <ABBAPOH@gmail.com> | 2020-04-06 10:37:03 +0000 |
| commit | 3e607549f61e9bc97da1d91edcd7d1a284224766 (patch) | |
| tree | e3ad6f6869a0e8551137ffc5232f9da8d78365e8 | |
| parent | 72de2d7c140a50fd5ef87f0168d39f47b600efda (diff) | |
Fix accessing temporary object data
Dectected by the 'clazy-returning-data-from-temporary' check
Change-Id: I2ab979bb1d58ea96a36d0331aeffa6a719d2f423
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
| -rw-r--r-- | src/lib/corelib/tools/id.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/lib/corelib/tools/id.cpp b/src/lib/corelib/tools/id.cpp index 6dd1147f2..33cfd60f7 100644 --- a/src/lib/corelib/tools/id.cpp +++ b/src/lib/corelib/tools/id.cpp @@ -269,9 +269,9 @@ Id Id::withPrefix(const char *prefix) const bool Id::operator==(const char *name) const { - const char *string = getStringFromId(m_id); - if (string && name) - return strcmp(string, name) == 0; + const auto string = getStringFromId(m_id); + if (!string.isNull() && name) + return strcmp(string.data(), name) == 0; else return false; } |