aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIvan Komissarov <abbapoh@gmail.com>2020-04-04 15:17:22 +0200
committerIvan Komissarov <ABBAPOH@gmail.com>2020-04-07 09:26:52 +0000
commit961b298e309bdf5d6ad969edc369299f15450538 (patch)
treec8bf73fa01e14bc15040ff551c7714b3d37c713f
parent1955a6a71e9c653c8033189543862bd1432b0a98 (diff)
clang-tidy: Fix 'google-readability-namespace-comments' warnings
Also, treat those as errors Change-Id: I33e5adef456b2c3445e00297d48770d99781aedd Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
-rw-r--r--.clang-tidy2
-rw-r--r--src/lib/corelib/api/changeset.cpp2
-rw-r--r--src/lib/corelib/buildgraph/productinstaller.cpp2
-rw-r--r--src/lib/corelib/tools/cleanoptions.cpp2
-rw-r--r--src/plugins/scanner/cpp/Lexer.cpp2
5 files changed, 5 insertions, 5 deletions
diff --git a/.clang-tidy b/.clang-tidy
index b8a8a8b65..81181c545 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -1,6 +1,6 @@
---
Checks: '-*,bugprone-*,cppcoreguidelines-interfaces-global-init,cppcoreguidelines-pro-type-cstyle-cast,cppcoreguidelines-pro-type-member-init,cppcoreguidelines-slicing,fuchsia-virtual-inheritance,google-build-explicit-make-pair,google-build-namespaces,google-global-names-in-headers,google-objc-*,google-readability-casting,google-readability-namespace-comments,google-runtime-operator,misc-definitions-in-headers,misc-misplaced-const,misc-new-delete-overloads,misc-non-copyable-objects,misc-redundant-expression,misc-static-assert,misc-unconventional-assign-operator,misc-uniqueptr-reset-release,misc-unused-*,modernize-avoid-bind,modernize-deprecated-headers,modernize-loop-convert,modernize-make-*,modernize-pass-by-value,modernize-redundant-void-arg,modernize-replace-*,modernize-return-braced-init-list,modernize-shrink-to-fit,modernize-unary-static-assert,modernize-use-auto,modernize-use-bool-literals,modernize-use-emplace,modernize-use-equals-*,modernize-use-noexcept,modernize-use-override,modernize-use-transparent-functors,modernize-use-using,performance-*,readability-avoid-const-params-in-decls,readability-container-size-empty,readability-delete-null-pointer,readability-deleted-default,readability-identifier-naming,readability-misleading-indentation,readability-misplaced-array-index,readability-non-const-parameter,readability-redundant-*,readability-simplify-boolean-expr,readability-static-definition-in-anonymous-namespace,readability-uniqueptr-delete-release'
-WarningsAsErrors: 'bugprone-*,-bugprone-suspicious-enum-usage,-bugprone-macro-parentheses,-bugprone-narrowing-conversions,misc-unused-*,modernize-make-*,modernize-pass-by-value,modernize-use-emplace,modernize-use-equals-default,modernize-use-override,performance-*'
+WarningsAsErrors: 'bugprone-*,-bugprone-suspicious-enum-usage,-bugprone-macro-parentheses,-bugprone-narrowing-conversions,google-*,-google-readability-casting,misc-unused-*,modernize-make-*,modernize-pass-by-value,modernize-use-emplace,modernize-use-equals-default,modernize-use-override,performance-*'
HeaderFilterRegex: ''
AnalyzeTemporaryDtors: false
CheckOptions:
diff --git a/src/lib/corelib/api/changeset.cpp b/src/lib/corelib/api/changeset.cpp
index 57ea3b569..773af328d 100644
--- a/src/lib/corelib/api/changeset.cpp
+++ b/src/lib/corelib/api/changeset.cpp
@@ -393,5 +393,5 @@ void ChangeSet::apply_helper()
m_cursor->endEditBlock();
}
-} // namespace Internal {
+} // namespace QbsQmlJS
diff --git a/src/lib/corelib/buildgraph/productinstaller.cpp b/src/lib/corelib/buildgraph/productinstaller.cpp
index ee56b02dd..80a76d7f5 100644
--- a/src/lib/corelib/buildgraph/productinstaller.cpp
+++ b/src/lib/corelib/buildgraph/productinstaller.cpp
@@ -250,5 +250,5 @@ void ProductInstaller::handleError(const QString &message)
m_logger.qbsWarning() << message;
}
-} // namespace Intern
+} // namespace Internal
} // namespace qbs
diff --git a/src/lib/corelib/tools/cleanoptions.cpp b/src/lib/corelib/tools/cleanoptions.cpp
index cef77468e..affc9b3f7 100644
--- a/src/lib/corelib/tools/cleanoptions.cpp
+++ b/src/lib/corelib/tools/cleanoptions.cpp
@@ -58,7 +58,7 @@ public:
bool logElapsedTime;
};
-}
+} // namespace Internal
/*!
* \class CleanOptions
diff --git a/src/plugins/scanner/cpp/Lexer.cpp b/src/plugins/scanner/cpp/Lexer.cpp
index 272d32d09..1e31b5ed4 100644
--- a/src/plugins/scanner/cpp/Lexer.cpp
+++ b/src/plugins/scanner/cpp/Lexer.cpp
@@ -667,4 +667,4 @@ void Lexer::scan_helper(Token *tok)
} // switch
}
-}
+} // namespace CPlusPlus