clang-tidy: Fix 'google-readability-casting' warnings

Also, treat those as errors.

Change-Id: I206844540eae6eef1e921f19453402a0c2874552
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

2 files changed, 6 insertions, 8 deletions

diff --git a/.clang-tidy b/.clang-tidy
index 9ff9487d5..98ce1a986 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -1,6 +1,6 @@
 ---
 Checks:          '-*,bugprone-*,cppcoreguidelines-interfaces-global-init,cppcoreguidelines-pro-type-cstyle-cast,cppcoreguidelines-pro-type-member-init,cppcoreguidelines-slicing,fuchsia-virtual-inheritance,google-build-explicit-make-pair,google-build-namespaces,google-global-names-in-headers,google-objc-*,google-readability-casting,google-readability-namespace-comments,google-runtime-operator,misc-definitions-in-headers,misc-misplaced-const,misc-new-delete-overloads,misc-non-copyable-objects,misc-redundant-expression,misc-static-assert,misc-unconventional-assign-operator,misc-uniqueptr-reset-release,misc-unused-*,modernize-avoid-bind,modernize-deprecated-headers,modernize-loop-convert,modernize-make-*,modernize-pass-by-value,modernize-redundant-void-arg,modernize-replace-*,modernize-return-braced-init-list,modernize-shrink-to-fit,modernize-unary-static-assert,modernize-use-auto,modernize-use-bool-literals,modernize-use-emplace,modernize-use-equals-*,modernize-use-noexcept,modernize-use-override,modernize-use-transparent-functors,modernize-use-using,performance-*,readability-avoid-const-params-in-decls,readability-container-size-empty,readability-delete-null-pointer,readability-deleted-default,readability-identifier-naming,readability-misleading-indentation,readability-misplaced-array-index,readability-non-const-parameter,readability-redundant-*,readability-simplify-boolean-expr,readability-static-definition-in-anonymous-namespace,readability-uniqueptr-delete-release'
-WarningsAsErrors: 'bugprone-*,-bugprone-macro-parentheses,-bugprone-narrowing-conversions,google-*,-google-readability-casting,misc-unused-*,modernize-make-*,modernize-pass-by-value,modernize-use-emplace,modernize-use-equals-default,modernize-use-override,performance-*'
+WarningsAsErrors: 'bugprone-*,-bugprone-macro-parentheses,-bugprone-narrowing-conversions,google-*,misc-unused-*,modernize-make-*,modernize-pass-by-value,modernize-use-emplace,modernize-use-equals-default,modernize-use-override,performance-*'
 HeaderFilterRegex: ''
 AnalyzeTemporaryDtors: false
 CheckOptions:
diff --git a/src/lib/corelib/parser/qmljsparser.cpp b/src/lib/corelib/parser/qmljsparser.cpp
index 3c8ae51e0..d2c87c7cb 100644
--- a/src/lib/corelib/parser/qmljsparser.cpp
+++ b/src/lib/corelib/parser/qmljsparser.cpp
@@ -328,7 +328,7 @@ case 26: {
 } break;
 
 case 27: {
-    const auto node = new (pool) AST::UiObjectInitializer((AST::UiObjectMemberList*)0);
+    const auto node = new (pool) AST::UiObjectInitializer(nullptr);
     node->lbraceToken = loc(1);
     node->rbraceToken = loc(2);
     sym(1).Node = node;
@@ -614,7 +614,7 @@ case 80: {
 } break;
 
 case 81: {
-  const auto node = new (pool) AST::ArrayLiteral((AST::Elision *) 0);
+  const auto node = new (pool) AST::ArrayLiteral(static_cast<AST::Elision *>(nullptr));
   node->lbracketToken = loc(1);
   node->rbracketToken = loc(2);
   sym(1).Node = node;
@@ -635,8 +635,7 @@ case 83: {
 } break;
 
 case 84: {
-  const auto node = new (pool) AST::ArrayLiteral(sym(2).ElementList->finish (),
-    (AST::Elision *) 0);
+  const auto node = new (pool) AST::ArrayLiteral(sym(2).ElementList->finish (), nullptr);
   node->lbracketToken = loc(1);
   node->commaToken = loc(3);
   node->rbracketToken = loc(4);
@@ -700,7 +699,7 @@ case 89: {
 } break;
 
 case 90: {
-  sym(1).Node = new (pool) AST::ElementList((AST::Elision *) 0, sym(1).Expression);
+  sym(1).Node = new (pool) AST::ElementList(nullptr, sym(1).Expression);
 } break;
 
 case 91: {
@@ -708,8 +707,7 @@ case 91: {
 } break;
 
 case 92: {
- const auto node = new (pool) AST::ElementList(sym(1).ElementList,
-    (AST::Elision *) 0, sym(3).Expression);
+ const auto node = new (pool) AST::ElementList(sym(1).ElementList, nullptr, sym(3).Expression);
   node->commaToken = loc(2);
   sym(1).Node = node;
 } break;