aboutsummaryrefslogtreecommitdiffstats
path: root/src/app/qbs-setup-toolchains
diff options
context:
space:
mode:
authorDavid Schulz <david.schulz@qt.io>2019-03-15 12:57:57 +0100
committerChristian Kandeler <christian.kandeler@qt.io>2019-03-15 15:03:47 +0000
commit206debe875417c9c7740eefe37349caecc64f164 (patch)
tree239152c66c3299c5887968438df61e4a22f097c5 /src/app/qbs-setup-toolchains
parent216b592da415e78b805204b58b5e15a208338004 (diff)
Fix version detection for MSVC 2017
The version number for recent MSVC2017 installation has changed to the format \d+\.\d+\.\d+\.\d+ and the second number is not guaranteed to be a zero. Change-Id: I13728d2a5ea3162c3ff29558757cd576a83f4983 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/app/qbs-setup-toolchains')
-rw-r--r--src/app/qbs-setup-toolchains/msvcprobe.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/app/qbs-setup-toolchains/msvcprobe.cpp b/src/app/qbs-setup-toolchains/msvcprobe.cpp
index 3bb99fd22..a6292d860 100644
--- a/src/app/qbs-setup-toolchains/msvcprobe.cpp
+++ b/src/app/qbs-setup-toolchains/msvcprobe.cpp
@@ -295,7 +295,7 @@ static std::vector<MSVC> installedMSVCs()
installInfos = installedMSVCsFromRegistry();
for (const MSVCInstallInfo &installInfo : installInfos) {
MSVC msvc;
- msvc.internalVsVersion = Version::fromString(installInfo.version);
+ msvc.internalVsVersion = Version::fromString(installInfo.version, true);
if (!msvc.internalVsVersion.isValid())
continue;
@@ -307,7 +307,7 @@ static std::vector<MSVC> installedMSVCs()
}
msvc.version = QString::number(Internal::VisualStudioVersionInfo(
- Version::fromString(installInfo.version)).marketingVersion());
+ msvc.internalVsVersion).marketingVersion());
if (msvc.version.isEmpty()) {
qbsWarning() << Tr::tr("Unknown MSVC version %1 found.").arg(installInfo.version);
continue;