diff options
| author | Ivan Komissarov <ABBAPOH@gmail.com> | 2019-11-24 16:12:46 +0900 |
|---|---|---|
| committer | Ivan Komissarov <ABBAPOH@gmail.com> | 2019-12-18 10:31:47 +0000 |
| commit | 6bc4dbe1ab05f94b8a8f16b650a5e73f3a671ebf (patch) | |
| tree | 588b783fdf74bc2004392fc1e139d498dccadc38 /src/app | |
| parent | e9eea57e5b0e048494cc57017eb2972f79cfd4a2 (diff) | |
Fix some 'performance-unnecessary-value-param' warnings with std::move
Change-Id: I1203d52814af644252ce1a9106662a266697ff72
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/app')
| -rw-r--r-- | src/app/qbs-setup-toolchains/iarewprobe.cpp | 2 | ||||
| -rw-r--r-- | src/app/qbs-setup-toolchains/keilprobe.cpp | 2 | ||||
| -rw-r--r-- | src/app/qbs-setup-toolchains/msvcprobe.cpp | 2 | ||||
| -rw-r--r-- | src/app/qbs-setup-toolchains/sdccprobe.cpp | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/src/app/qbs-setup-toolchains/iarewprobe.cpp b/src/app/qbs-setup-toolchains/iarewprobe.cpp index 7f710532a..e1a56b072 100644 --- a/src/app/qbs-setup-toolchains/iarewprobe.cpp +++ b/src/app/qbs-setup-toolchains/iarewprobe.cpp @@ -245,7 +245,7 @@ void createIarProfile(const QFileInfo &compiler, Settings *settings, QString profileName) { const ToolchainInstallInfo info = {compiler, Version{}}; - createIarProfileHelper(info, settings, profileName); + createIarProfileHelper(info, settings, std::move(profileName)); } void iarProbe(Settings *settings, std::vector<Profile> &profiles) diff --git a/src/app/qbs-setup-toolchains/keilprobe.cpp b/src/app/qbs-setup-toolchains/keilprobe.cpp index 728c5b3f2..9fe751346 100644 --- a/src/app/qbs-setup-toolchains/keilprobe.cpp +++ b/src/app/qbs-setup-toolchains/keilprobe.cpp @@ -255,7 +255,7 @@ void createKeilProfile(const QFileInfo &compiler, Settings *settings, QString profileName) { const ToolchainInstallInfo info = {compiler, Version{}}; - createKeilProfileHelper(info, settings, profileName); + createKeilProfileHelper(info, settings, std::move(profileName)); } void keilProbe(Settings *settings, std::vector<Profile> &profiles) diff --git a/src/app/qbs-setup-toolchains/msvcprobe.cpp b/src/app/qbs-setup-toolchains/msvcprobe.cpp index 9f2faaa99..f2b53d6a5 100644 --- a/src/app/qbs-setup-toolchains/msvcprobe.cpp +++ b/src/app/qbs-setup-toolchains/msvcprobe.cpp @@ -90,7 +90,7 @@ static void setQtHelperProperties(Profile &p, const MSVC *msvc) static void addMSVCPlatform(Settings *settings, std::vector<Profile> &profiles, QString name, MSVC *msvc) { qbsInfo() << Tr::tr("Setting up profile '%1'.").arg(name); - Profile p(name, settings); + Profile p(std::move(name), settings); p.removeProfile(); p.setValue(QStringLiteral("qbs.targetPlatform"), QStringLiteral("windows")); p.setValue(QStringLiteral("qbs.toolchain"), QStringList(QStringLiteral("msvc"))); diff --git a/src/app/qbs-setup-toolchains/sdccprobe.cpp b/src/app/qbs-setup-toolchains/sdccprobe.cpp index 3899ac3c9..559492280 100644 --- a/src/app/qbs-setup-toolchains/sdccprobe.cpp +++ b/src/app/qbs-setup-toolchains/sdccprobe.cpp @@ -255,7 +255,7 @@ void createSdccProfile(const QFileInfo &compiler, Settings *settings, QString profileName) { const ToolchainInstallInfo info = {compiler, Version{}}; - createSdccProfileHelper(info, settings, profileName); + createSdccProfileHelper(info, settings, std::move(profileName)); } void sdccProbe(Settings *settings, std::vector<Profile> &profiles) |