diff options
| author | Christian Kandeler <christian.kandeler@digia.com> | 2013-04-08 18:18:16 +0200 |
|---|---|---|
| committer | Joerg Bornemann <joerg.bornemann@digia.com> | 2013-04-12 14:19:12 +0200 |
| commit | 1d9c080428dcd5e8c1d08598d6542d87f1ca1819 (patch) | |
| tree | 38282acbb95c921595dffec93a6dd99aaa61c24f /src/lib/buildgraph/cycledetector.h | |
| parent | f17fd5d56a758a28ef5da04b2be83ed558f7cba6 (diff) | |
Remove structural redundancy in project and product classes.
We had two project classes, each holding a list of products
that was structurally identical, except that no BuildProduct
object existed for a disabled ResolvedProduct. The same kind
of duplication also happened for product dependencies.
This patch gets rid of these parallel structures. BuildProject
and BuildProduct are largely being demoted to data holders and are
aggregated by ResolvedProject and ResolvedProduct, respectively.
The resulting project structure should be easier to understand
and maintain.
Change-Id: I68beef60b9e0d62258f6a8337c9015864e18bd80
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Diffstat (limited to 'src/lib/buildgraph/cycledetector.h')
| -rw-r--r-- | src/lib/buildgraph/cycledetector.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/buildgraph/cycledetector.h b/src/lib/buildgraph/cycledetector.h index 9f47b03de..61ddac0b1 100644 --- a/src/lib/buildgraph/cycledetector.h +++ b/src/lib/buildgraph/cycledetector.h @@ -42,7 +42,7 @@ class CycleDetector : public ArtifactVisitor public: CycleDetector(const Logger &logger); - void visitProject(const BuildProjectConstPtr &project); + void visitProject(const ResolvedProjectConstPtr &project); void visitArtifact(Artifact *artifact); private: |