diff options
author | Christian Kandeler <christian.kandeler@digia.com> | 2014-07-15 17:07:53 +0200 |
---|---|---|
committer | Christian Kandeler <christian.kandeler@digia.com> | 2014-07-16 10:57:35 +0200 |
commit | 42beadbf28523c96e0790631a4e294de0e9b3f03 (patch) | |
tree | 7d2a67b9ac1d163ad87291157de66aa0094a93f2 /src/lib/corelib/api/internaljobs.cpp | |
parent | 5154ca52e0fffe840411599b26b30a72ec65b77f (diff) |
Fix race condition in project locking.
We did the unlocking in a different thread, which does not seem like a
good idea.
Change-Id: Id3427bf52e993011d0f18b0d7f526901e31e9c30
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Diffstat (limited to 'src/lib/corelib/api/internaljobs.cpp')
-rw-r--r-- | src/lib/corelib/api/internaljobs.cpp | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/src/lib/corelib/api/internaljobs.cpp b/src/lib/corelib/api/internaljobs.cpp index ededa3279..a3789f31d 100644 --- a/src/lib/corelib/api/internaljobs.cpp +++ b/src/lib/corelib/api/internaljobs.cpp @@ -55,12 +55,6 @@ namespace qbs { namespace Internal { -static void unlockBuildGraph(const TopLevelProjectPtr &project) -{ - QBS_ASSERT(project->locked, return); - project->locked = false; -} - class JobObserver : public ProgressObserver { public: @@ -371,7 +365,6 @@ void InternalBuildJob::handleFinished() void InternalBuildJob::emitFinished() { - unlockBuildGraph(project()); emit finished(this); } @@ -397,7 +390,6 @@ void InternalCleanJob::start() setError(error); } storeBuildGraph(); - unlockBuildGraph(project()); emit finished(this); } @@ -427,7 +419,6 @@ void InternalInstallJob::start() } catch (const ErrorInfo &error) { setError(error); } - unlockBuildGraph(m_project); emit finished(this); } |