Do not share product properties with artifacts.

Since products potentially share their property maps with their groups,
artifacts get product properties such as "name" and
"destinationDirectory". This is strange and can mess with change
tracking. Therefore we split up the product's property map in two: One
contains the module properties and is potentially shared with groups,
the other has the actual product properties and is not shared.
This patch also removes a workaround from an autotest that was required
until now to prevent a false positive in change tracking.

Change-Id: Ia1f1f0ce32669fd893a99f809753df526bf1442a
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

2 files changed, 2 insertions, 2 deletions

diff --git a/src/lib/corelib/api/project.cpp b/src/lib/corelib/api/project.cpp
index 8907e54a8..dd4d57a97 100644
--- a/src/lib/corelib/api/project.cpp
+++ b/src/lib/corelib/api/project.cpp
@@ -329,7 +329,7 @@ void ProjectPrivate::addGroup(const ProductData &product, const QString &groupNa
     resolvedGroup->location = groupInserter.itemPosition();
     resolvedGroup->enabled = true;
     resolvedGroup->name = groupName;
-    resolvedGroup->properties = resolvedProduct->properties;
+    resolvedGroup->properties = resolvedProduct->moduleProperties;
     resolvedGroup->overrideTags = false;
     resolvedProduct->groups << resolvedGroup;
     foreach (const ProductData &newProduct, m_projectData.allProducts()) {
diff --git a/src/lib/corelib/api/runenvironment.cpp b/src/lib/corelib/api/runenvironment.cpp
index 25ec6ab46..b0be216f8 100644
--- a/src/lib/corelib/api/runenvironment.cpp
+++ b/src/lib/corelib/api/runenvironment.cpp
@@ -132,7 +132,7 @@ int RunEnvironment::runShell()
 int RunEnvironment::runTarget(const QString &targetBin, const QStringList &arguments)
 {
     const QStringList targetOS = PropertyFinder().propertyValue(
-                d->resolvedProduct->properties->value(),
+                d->resolvedProduct->moduleProperties->value(),
                 QLatin1String("qbs"),
                 QLatin1String("targetOS")).toStringList();