diff options
| author | Christian Kandeler <christian.kandeler@qt.io> | 2017-11-13 17:19:32 +0100 |
|---|---|---|
| committer | Christian Kandeler <christian.kandeler@qt.io> | 2017-11-30 16:12:55 +0000 |
| commit | c03f79f3af806cdec5c938d267486d338eaaab5d (patch) | |
| tree | 763949fc5edda34de287a19d4a04461f588e3987 /src/lib/corelib/buildgraph/depscanner.cpp | |
| parent | a5cc49f2c62cfd4094c6a8bccd7741ca9ee7e072 (diff) | |
Remove as many dynamic_casts as possible
According to our benchmarker, this speeds up rule execution by three per
cent.
Change-Id: Iaf146ba6073b897d19e0fe470d7b0dc4a04d264c
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
Diffstat (limited to 'src/lib/corelib/buildgraph/depscanner.cpp')
| -rw-r--r-- | src/lib/corelib/buildgraph/depscanner.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/lib/corelib/buildgraph/depscanner.cpp b/src/lib/corelib/buildgraph/depscanner.cpp index 0efe4af47..d20c301f7 100644 --- a/src/lib/corelib/buildgraph/depscanner.cpp +++ b/src/lib/corelib/buildgraph/depscanner.cpp @@ -175,10 +175,9 @@ QStringList UserDependencyScanner::collectDependencies(FileResourceBase *file, c { Q_UNUSED(fileTags); // ### support user dependency scanners for file deps - Artifact *artifact = dynamic_cast<Artifact *>(file); - if (!artifact) + if (file->fileType() != FileResourceBase::FileTypeArtifact) return QStringList(); - return evaluate(artifact, m_scanner->scanScript); + return evaluate(static_cast<Artifact *>(file), m_scanner->scanScript); } bool UserDependencyScanner::recursive() const |