diff options
author | Christian Kandeler <christian.kandeler@qt.io> | 2018-04-19 15:07:02 +0200 |
---|---|---|
committer | Christian Kandeler <christian.kandeler@qt.io> | 2018-04-20 11:15:36 +0000 |
commit | 5e1b6c08395bd47a544cc946ebe784484454408d (patch) | |
tree | a2db4930aafca7a3c8170039a2bd53bddaa6c219 /src/lib/corelib/generators | |
parent | b46c1ebb5f10f06f748047a6ecffed0d08bfbf6c (diff) |
Clean up the ProjectGenerator interface
Make the virtual generate() function private; it is only supposed to be
called from within this class. Merge the two "private:" sections while
we're at it.
Change-Id: I43dbd5d45e8c5d803f1bfbf088dbe1944a59c05b
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Diffstat (limited to 'src/lib/corelib/generators')
-rw-r--r-- | src/lib/corelib/generators/generator.h | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/src/lib/corelib/generators/generator.h b/src/lib/corelib/generators/generator.h index 8c7bfde8b..abb804d62 100644 --- a/src/lib/corelib/generators/generator.h +++ b/src/lib/corelib/generators/generator.h @@ -66,8 +66,6 @@ public: */ virtual QString generatorName() const = 0; - virtual void generate() = 0; - void generate(const QList<Project> &projects, const QList<QVariantMap> &buildConfigurations, const InstallOptions &installOptions, @@ -78,19 +76,19 @@ public: QFileInfo qbsExecutableFilePath() const; QString qbsSettingsDir() const; -private: - QList<Project> projects() const; - QList<QVariantMap> buildConfigurations() const; - QVariantMap buildConfiguration(const Project &project) const; - - QStringList buildConfigurationCommandLine(const Project &project) const; - protected: ProjectGenerator(); const Internal::Logger &logger() const; private: + virtual void generate() = 0; + + QList<Project> projects() const; + QList<QVariantMap> buildConfigurations() const; + QVariantMap buildConfiguration(const Project &project) const; + QStringList buildConfigurationCommandLine(const Project &project) const; + ProjectGeneratorPrivate *d; }; |