aboutsummaryrefslogtreecommitdiffstats
path: root/src/lib/corelib/language/moduleloader.cpp
diff options
context:
space:
mode:
authorIvan Komissarov <ABBAPOH@gmail.com>2019-02-19 23:24:16 +0100
committerIvan Komissarov <ABBAPOH@gmail.com>2019-02-20 13:22:38 +0000
commit4146f1067905c3718b0504b510367bb4349b4622 (patch)
tree2554f9fb125bbd117f43ef794cc2f1fb903cf26f /src/lib/corelib/language/moduleloader.cpp
parent5a2e0c4d33c2aedb81adea922cfde824b1df92ad (diff)
Add const-references for non trivial types in range-for loops
This fixes -Wclazy-range-loop Change-Id: I5424d2626d6134ac7be2ce70b83f5a617f58dd7e Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/lib/corelib/language/moduleloader.cpp')
-rw-r--r--src/lib/corelib/language/moduleloader.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/lib/corelib/language/moduleloader.cpp b/src/lib/corelib/language/moduleloader.cpp
index 74d62c818..882ac7061 100644
--- a/src/lib/corelib/language/moduleloader.cpp
+++ b/src/lib/corelib/language/moduleloader.cpp
@@ -599,7 +599,7 @@ void ModuleLoader::handleTopLevelProject(ModuleLoaderResult *loadResult, Item *p
for (Item * const exportItem : m_exportsWithDeferredDependsItems)
normalizeDependencies(nullptr, DeferredDependsContext(nullptr, exportItem));
- for (const auto deferredDependsData : m_productsWithDeferredDependsItems) {
+ for (const auto &deferredDependsData : m_productsWithDeferredDependsItems) {
ProductContext * const productContext = deferredDependsData.first;
m_reader->setExtraSearchPathsStack(productContext->project->searchPathsStack);
try {
@@ -1877,7 +1877,7 @@ static void adjustParametersScopes(Item *item, Item *scope)
return;
}
- for (auto value : item->properties()) {
+ for (const auto &value : item->properties()) {
if (value->type() != Value::ItemValueType)
continue;
adjustParametersScopes(std::static_pointer_cast<ItemValue>(value)->item(), scope);
@@ -3415,7 +3415,7 @@ void ModuleLoader::instantiateModule(ProductContext *productContext, Item *expor
}
// For foo.bar in modulePrototype create an item foo in moduleInstance.
- for (auto iip : instanceItemProperties(modulePrototype)) {
+ for (const auto &iip : instanceItemProperties(modulePrototype)) {
if (iip.second->item()->properties().empty())
continue;
qCDebug(lcModuleLoader) << "The prototype of " << moduleName