Fix calls to non-const begin()/end() in range-for loops

This fixes -Wclazy-range-loop

Change-Id: I08a435b700017cdbe27fbfdbda6e26840d9a3568
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>

1 files changed, 4 insertions, 2 deletions

diff --git a/src/lib/corelib/tools/msvcinfo.cpp b/src/lib/corelib/tools/msvcinfo.cpp
index f51ba8ba2..cbec7b457 100644
--- a/src/lib/corelib/tools/msvcinfo.cpp
+++ b/src/lib/corelib/tools/msvcinfo.cpp
@@ -70,7 +70,8 @@ public:
     TemporaryEnvChanger(const QProcessEnvironment &envChanges) : m_locker(envMutex)
     {
         QProcessEnvironment currentEnv = QProcessEnvironment::systemEnvironment();
-        for (const QString &key : envChanges.keys()) {
+        const auto keys = envChanges.keys();
+        for (const QString &key : keys) {
             m_changesToRestore.insert(key, currentEnv.value(key));
             qputenv(qPrintable(key), qPrintable(envChanges.value(key)));
         }
@@ -78,7 +79,8 @@ public:
 
     ~TemporaryEnvChanger()
     {
-        for (const QString &key : m_changesToRestore.keys())
+        const auto keys = m_changesToRestore.keys();
+        for (const QString &key : keys)
             qputenv(qPrintable(key), qPrintable(m_changesToRestore.value(key)));
     }