aboutsummaryrefslogtreecommitdiffstats
path: root/src/lib/corelib
diff options
context:
space:
mode:
authorChristian Kandeler <christian.kandeler@digia.com>2014-08-19 15:02:16 +0200
committerJoerg Bornemann <joerg.bornemann@digia.com>2014-08-20 14:26:47 +0200
commit635ce04767a9e59e88f6a6fcde1f74c9ff247e98 (patch)
treeb6c1d52660eac7533b96930181de0322fb243adc /src/lib/corelib
parent82c459ea14dcd8981e397038a30c501a6c3d7697 (diff)
Fix toJsLiteral(QVariant).
For QVariants of QString type, toJsLiteral(QString) must be called instead of the simplistic conversion that currently takes place. This fixes handling of backslashes and double quotes. Change-Id: I70c1ee4bc2c6b913c6f71fa644671bf33525966f Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Diffstat (limited to 'src/lib/corelib')
-rw-r--r--src/lib/corelib/tools/scripttools.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/corelib/tools/scripttools.cpp b/src/lib/corelib/tools/scripttools.cpp
index 3ebca42a9..64cbaa7d6 100644
--- a/src/lib/corelib/tools/scripttools.cpp
+++ b/src/lib/corelib/tools/scripttools.cpp
@@ -111,7 +111,7 @@ QString toJSLiteral(const QVariant &val)
if (val.type() == QVariant::Bool)
return val.toBool() ? QLatin1String("true") : QLatin1String("false");
if (val.canConvert(QVariant::String))
- return QLatin1Char('"') + val.toString() + QLatin1Char('"');
+ return toJSLiteral(val.toString());
return QString::fromLatin1("Unconvertible type %1").arg(QLatin1String(val.typeName()));
}