diff options
| author | hjk <hjk@qt.io> | 2019-05-15 17:35:15 +0200 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2019-05-16 12:38:26 +0000 |
| commit | 4a75e75cec58298783a314ace350cab1347fc887 (patch) | |
| tree | 22eeaeb2c100cf0d38e27ae79dcf8fb49aad935c /src/lib | |
| parent | 6d32d72df0879887a1a4cf1b5794550bfb0deeb5 (diff) | |
Use std::vector in ItemPool
Is:
text data bss dec hex filename
11490 8 0 11498 2cea itempool.o
Was:
text data bss dec hex filename
12425 8 0 12433 3091 itempool.o-orig
Also, less symbols.
Change-Id: I6f90b126933f5fa6d00f5e1097faaa4276613a6a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/lib')
| -rw-r--r-- | src/lib/corelib/language/itempool.cpp | 4 | ||||
| -rw-r--r-- | src/lib/corelib/language/itempool.h | 5 |
2 files changed, 4 insertions, 5 deletions
diff --git a/src/lib/corelib/language/itempool.cpp b/src/lib/corelib/language/itempool.cpp index 8ec6b63d1..3da8b947b 100644 --- a/src/lib/corelib/language/itempool.cpp +++ b/src/lib/corelib/language/itempool.cpp @@ -49,8 +49,8 @@ ItemPool::ItemPool() ItemPool::~ItemPool() { - for (ItemVector::const_iterator it = m_items.cbegin(); it != m_items.cend(); ++it) - (*it)->~Item(); + for (Item *item : m_items) + item->~Item(); } Item *ItemPool::allocateItem(const ItemType &type) diff --git a/src/lib/corelib/language/itempool.h b/src/lib/corelib/language/itempool.h index 8ee8562d7..ef4be7639 100644 --- a/src/lib/corelib/language/itempool.h +++ b/src/lib/corelib/language/itempool.h @@ -43,7 +43,7 @@ #include <parser/qmljsmemorypool_p.h> #include <tools/qbs_export.h> -#include <QtCore/qlist.h> +#include <vector> namespace qbs { namespace Internal { @@ -62,8 +62,7 @@ public: private: QbsQmlJS::MemoryPool m_pool; - using ItemVector = QList<Item *>; - ItemVector m_items; + std::vector<Item *> m_items; }; } // namespace Internal |