diff options
author | Ivan Komissarov <ABBAPOH@gmail.com> | 2019-08-07 13:35:13 +0200 |
---|---|---|
committer | Ivan Komissarov <ABBAPOH@gmail.com> | 2019-08-16 09:59:44 +0000 |
commit | bce7328b597443df77855e6afd587c268ced91f4 (patch) | |
tree | c54061a7ad77ddf89799d6487e7f448de39c953a /src/lib | |
parent | aacca006f48f2214f2ea0c7293d3199b3ab33fbc (diff) |
Use different names for virtual functions in INodeVisitor
This fixes compiler warnings about hidden virtual functions in derived classes
Change-Id: I3b53d07263f66133a41353eb6cfe05e1f3b20cc3
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/lib')
-rw-r--r-- | src/lib/corelib/generators/ixmlnodevisitor.h | 16 | ||||
-rw-r--r-- | src/lib/corelib/generators/xmlproject.cpp | 4 | ||||
-rw-r--r-- | src/lib/corelib/generators/xmlprojectwriter.cpp | 8 | ||||
-rw-r--r-- | src/lib/corelib/generators/xmlprojectwriter.h | 8 | ||||
-rw-r--r-- | src/lib/corelib/generators/xmlproperty.cpp | 4 | ||||
-rw-r--r-- | src/lib/corelib/generators/xmlpropertygroup.cpp | 4 | ||||
-rw-r--r-- | src/lib/corelib/generators/xmlworkspace.cpp | 4 | ||||
-rw-r--r-- | src/lib/corelib/generators/xmlworkspacewriter.cpp | 8 | ||||
-rw-r--r-- | src/lib/corelib/generators/xmlworkspacewriter.h | 8 |
9 files changed, 32 insertions, 32 deletions
diff --git a/src/lib/corelib/generators/ixmlnodevisitor.h b/src/lib/corelib/generators/ixmlnodevisitor.h index 6d62c86ed..d3d118975 100644 --- a/src/lib/corelib/generators/ixmlnodevisitor.h +++ b/src/lib/corelib/generators/ixmlnodevisitor.h @@ -49,17 +49,17 @@ class QBS_EXPORT INodeVisitor public: virtual ~INodeVisitor() {} - virtual void visitStart(const Workspace *workspace) { Q_UNUSED(workspace) } - virtual void visitEnd(const Workspace *workspace) { Q_UNUSED(workspace) } + virtual void visitWorkspaceStart(const Workspace *workspace) { Q_UNUSED(workspace) } + virtual void visitWorkspaceEnd(const Workspace *workspace) { Q_UNUSED(workspace) } - virtual void visitStart(const Project *project) { Q_UNUSED(project) } - virtual void visitEnd(const Project *project) { Q_UNUSED(project) } + virtual void visitProjectStart(const Project *project) { Q_UNUSED(project) } + virtual void visitProjectEnd(const Project *project) { Q_UNUSED(project) } - virtual void visitStart(const Property *property) = 0; - virtual void visitEnd(const Property *property) = 0; + virtual void visitPropertyStart(const Property *property) = 0; + virtual void visitPropertyEnd(const Property *property) = 0; - virtual void visitStart(const PropertyGroup *propertyGroup) = 0; - virtual void visitEnd(const PropertyGroup *propertyGroup) = 0; + virtual void visitPropertyGroupStart(const PropertyGroup *propertyGroup) = 0; + virtual void visitPropertyGroupEnd(const PropertyGroup *propertyGroup) = 0; }; } // namespace xml diff --git a/src/lib/corelib/generators/xmlproject.cpp b/src/lib/corelib/generators/xmlproject.cpp index becd31dda..e2ac951aa 100644 --- a/src/lib/corelib/generators/xmlproject.cpp +++ b/src/lib/corelib/generators/xmlproject.cpp @@ -37,12 +37,12 @@ namespace xml { void Project::accept(INodeVisitor *visitor) const { - visitor->visitStart(this); + visitor->visitProjectStart(this); for (const auto &child : children()) child->accept(visitor); - visitor->visitEnd(this); + visitor->visitProjectEnd(this); } } // namespace xml diff --git a/src/lib/corelib/generators/xmlprojectwriter.cpp b/src/lib/corelib/generators/xmlprojectwriter.cpp index 5b96564bd..5554e5935 100644 --- a/src/lib/corelib/generators/xmlprojectwriter.cpp +++ b/src/lib/corelib/generators/xmlprojectwriter.cpp @@ -58,25 +58,25 @@ bool ProjectWriter::write(const Project *project) return m_device->good(); } -void ProjectWriter::visitStart(const Property *property) +void ProjectWriter::visitPropertyStart(const Property *property) { const auto value = property->value().toString(); const auto name = QString::fromUtf8(property->name()); m_writer->writeTextElement(name, value); } -void ProjectWriter::visitEnd(const Property *property) +void ProjectWriter::visitPropertyEnd(const Property *property) { Q_UNUSED(property) } -void ProjectWriter::visitStart(const PropertyGroup *propertyGroup) +void ProjectWriter::visitPropertyGroupStart(const PropertyGroup *propertyGroup) { const auto name = QString::fromUtf8(propertyGroup->name()); m_writer->writeStartElement(name); } -void ProjectWriter::visitEnd(const PropertyGroup *propertyGroup) +void ProjectWriter::visitPropertyGroupEnd(const PropertyGroup *propertyGroup) { Q_UNUSED(propertyGroup) m_writer->writeEndElement(); diff --git a/src/lib/corelib/generators/xmlprojectwriter.h b/src/lib/corelib/generators/xmlprojectwriter.h index da4100a92..8198de61c 100644 --- a/src/lib/corelib/generators/xmlprojectwriter.h +++ b/src/lib/corelib/generators/xmlprojectwriter.h @@ -52,11 +52,11 @@ protected: QXmlStreamWriter *writer() const; private: - void visitStart(const Property *property) final; - void visitEnd(const Property *property) final; + void visitPropertyStart(const Property *property) final; + void visitPropertyEnd(const Property *property) final; - void visitStart(const PropertyGroup *propertyGroup) final; - void visitEnd(const PropertyGroup *propertyGroup) final; + void visitPropertyGroupStart(const PropertyGroup *propertyGroup) final; + void visitPropertyGroupEnd(const PropertyGroup *propertyGroup) final; std::ostream *m_device = nullptr; QByteArray m_buffer; diff --git a/src/lib/corelib/generators/xmlproperty.cpp b/src/lib/corelib/generators/xmlproperty.cpp index ae41eab4a..2fe5a0147 100644 --- a/src/lib/corelib/generators/xmlproperty.cpp +++ b/src/lib/corelib/generators/xmlproperty.cpp @@ -43,12 +43,12 @@ Property::Property(QByteArray name, QVariant value) void Property::accept(INodeVisitor *visitor) const { - visitor->visitStart(this); + visitor->visitPropertyStart(this); for (const auto &child : children()) child->accept(visitor); - visitor->visitEnd(this); + visitor->visitPropertyEnd(this); } } // namespace xml diff --git a/src/lib/corelib/generators/xmlpropertygroup.cpp b/src/lib/corelib/generators/xmlpropertygroup.cpp index 2111b9b1e..398d68e77 100644 --- a/src/lib/corelib/generators/xmlpropertygroup.cpp +++ b/src/lib/corelib/generators/xmlpropertygroup.cpp @@ -54,12 +54,12 @@ void PropertyGroup::appendMultiLineProperty( void PropertyGroup::accept(INodeVisitor *visitor) const { - visitor->visitStart(this); + visitor->visitPropertyGroupStart(this); for (const auto &child : children()) child->accept(visitor); - visitor->visitEnd(this); + visitor->visitPropertyGroupEnd(this); } } // namespace xml diff --git a/src/lib/corelib/generators/xmlworkspace.cpp b/src/lib/corelib/generators/xmlworkspace.cpp index 8913ceffd..7ce3f5164 100644 --- a/src/lib/corelib/generators/xmlworkspace.cpp +++ b/src/lib/corelib/generators/xmlworkspace.cpp @@ -53,12 +53,12 @@ Workspace::Workspace(const QString &workspacePath) void Workspace::accept(INodeVisitor *visitor) const { - visitor->visitStart(this); + visitor->visitWorkspaceStart(this); for (const auto &child : children()) child->accept(visitor); - visitor->visitEnd(this); + visitor->visitWorkspaceEnd(this); } } // namespace xml diff --git a/src/lib/corelib/generators/xmlworkspacewriter.cpp b/src/lib/corelib/generators/xmlworkspacewriter.cpp index 2358d4047..c88cb06d0 100644 --- a/src/lib/corelib/generators/xmlworkspacewriter.cpp +++ b/src/lib/corelib/generators/xmlworkspacewriter.cpp @@ -58,25 +58,25 @@ bool WorkspaceWriter::write(const Workspace *workspace) return m_device->good(); } -void WorkspaceWriter::visitStart(const Property *property) +void WorkspaceWriter::visitPropertyStart(const Property *property) { const auto value = property->value().toString(); const auto name = QString::fromUtf8(property->name()); m_writer->writeTextElement(name, value); } -void WorkspaceWriter::visitEnd(const Property *property) +void WorkspaceWriter::visitPropertyEnd(const Property *property) { Q_UNUSED(property) } -void WorkspaceWriter::visitStart(const PropertyGroup *propertyGroup) +void WorkspaceWriter::visitPropertyGroupStart(const PropertyGroup *propertyGroup) { const auto name = QString::fromUtf8(propertyGroup->name()); m_writer->writeStartElement(name); } -void WorkspaceWriter::visitEnd(const PropertyGroup *propertyGroup) +void WorkspaceWriter::visitPropertyGroupEnd(const PropertyGroup *propertyGroup) { Q_UNUSED(propertyGroup) m_writer->writeEndElement(); diff --git a/src/lib/corelib/generators/xmlworkspacewriter.h b/src/lib/corelib/generators/xmlworkspacewriter.h index 73e7d0686..343face5d 100644 --- a/src/lib/corelib/generators/xmlworkspacewriter.h +++ b/src/lib/corelib/generators/xmlworkspacewriter.h @@ -52,11 +52,11 @@ protected: QXmlStreamWriter *writer() const; private: - void visitStart(const Property *property) final; - void visitEnd(const Property *property) final; + void visitPropertyStart(const Property *property) final; + void visitPropertyEnd(const Property *property) final; - void visitStart(const PropertyGroup *propertyGroup) final; - void visitEnd(const PropertyGroup *propertyGroup) final; + void visitPropertyGroupStart(const PropertyGroup *propertyGroup) final; + void visitPropertyGroupEnd(const PropertyGroup *propertyGroup) final; std::ostream *m_device = nullptr; QByteArray m_buffer; |