STL compatibility: use push_back() instead of append()

...or operator<< if the argument was itself a list, or brace init where
appropriate.

This is a simple find and replace with manual sanity check.

Change-Id: I94b79cbf3752192dd258001bf1dfcd46f58ca352
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

4 files changed, 9 insertions, 9 deletions

diff --git a/src/plugins/generator/clangcompilationdb/clangcompilationdbgenerator.cpp b/src/plugins/generator/clangcompilationdb/clangcompilationdbgenerator.cpp
index a3407cb09..0f94f2b2b 100644
--- a/src/plugins/generator/clangcompilationdb/clangcompilationdbgenerator.cpp
+++ b/src/plugins/generator/clangcompilationdb/clangcompilationdbgenerator.cpp
@@ -92,7 +92,7 @@ void ClangCompilationDatabaseGenerator::generate()
                     for (const RuleCommand &rule : rules) {
                         if (rule.type() != RuleCommand::ProcessCommandType)
                             continue;
-                        database.append(createEntry(filePath, buildDir, rule));
+                        database.push_back(createEntry(filePath, buildDir, rule));
                     }
                 }
             }
diff --git a/src/plugins/generator/visualstudio/solution/visualstudiosolution.cpp b/src/plugins/generator/visualstudio/solution/visualstudiosolution.cpp
index a6d572425..fbd6a3848 100644
--- a/src/plugins/generator/visualstudio/solution/visualstudiosolution.cpp
+++ b/src/plugins/generator/visualstudio/solution/visualstudiosolution.cpp
@@ -76,7 +76,7 @@ QList<VisualStudioSolutionFileProject *> VisualStudioSolution::fileProjects() co
     QList<VisualStudioSolutionFileProject *> list;
     for (const auto &project : d->projects)
         if (auto fileProject = qobject_cast<VisualStudioSolutionFileProject *>(project))
-            list.append(fileProject);
+            list.push_back(fileProject);
     return list;
 }
 
@@ -85,13 +85,13 @@ QList<VisualStudioSolutionFolderProject *> VisualStudioSolution::folderProjects(
     QList<VisualStudioSolutionFolderProject *> list;
     for (const auto &project : d->projects)
         if (auto folderProject = qobject_cast<VisualStudioSolutionFolderProject *>(project))
-            list.append(folderProject);
+            list.push_back(folderProject);
     return list;
 }
 
 void VisualStudioSolution::appendProject(IVisualStudioSolutionProject *project)
 {
-    d->projects.append(project);
+    d->projects.push_back(project);
 }
 
 QList<VisualStudioSolutionFileProject *> VisualStudioSolution::dependencies(
@@ -103,7 +103,7 @@ QList<VisualStudioSolutionFileProject *> VisualStudioSolution::dependencies(
 void VisualStudioSolution::addDependency(VisualStudioSolutionFileProject *project,
                                          VisualStudioSolutionFileProject *dependency)
 {
-    d->dependencies[project].append(dependency);
+    d->dependencies[project].push_back(dependency);
 }
 
 QList<VisualStudioSolutionGlobalSection *> VisualStudioSolution::globalSections() const
@@ -113,7 +113,7 @@ QList<VisualStudioSolutionGlobalSection *> VisualStudioSolution::globalSections(
 
 void VisualStudioSolution::appendGlobalSection(VisualStudioSolutionGlobalSection *globalSection)
 {
-    d->globalSections.append(globalSection);
+    d->globalSections.push_back(globalSection);
 }
 
 } // namespace qbs
diff --git a/src/plugins/generator/visualstudio/visualstudiogenerator.cpp b/src/plugins/generator/visualstudio/visualstudiogenerator.cpp
index e5cf62003..02c5d710d 100644
--- a/src/plugins/generator/visualstudio/visualstudiogenerator.cpp
+++ b/src/plugins/generator/visualstudio/visualstudiogenerator.cpp
@@ -169,7 +169,7 @@ void VisualStudioGenerator::addPropertySheets(const GeneratableProject &project)
 {
     {
         const auto fileName = QStringLiteral("qbs.props");
-        d->propertySheetNames.append({ fileName, true });
+        d->propertySheetNames.push_back({ fileName, true });
         d->msbuildProjects.insert(project.baseBuildDirectory().absoluteFilePath(fileName),
                                 std::make_shared<MSBuildSolutionPropertiesProject>(
                                     d->versionInfo, project,
@@ -178,7 +178,7 @@ void VisualStudioGenerator::addPropertySheets(const GeneratableProject &project)
 
     {
         const auto fileName = QStringLiteral("qbs-shared.props");
-        d->propertySheetNames.append({ fileName, false });
+        d->propertySheetNames.push_back({ fileName, false });
         d->msbuildProjects.insert(project.baseBuildDirectory().absoluteFilePath(fileName),
                                 std::make_shared<MSBuildSharedSolutionPropertiesProject>(
                                     d->versionInfo, project,
diff --git a/src/plugins/scanner/cpp/cppscanner.cpp b/src/plugins/scanner/cpp/cppscanner.cpp
index 84bda61b6..739b863de 100644
--- a/src/plugins/scanner/cpp/cppscanner.cpp
+++ b/src/plugins/scanner/cpp/cppscanner.cpp
@@ -169,7 +169,7 @@ static void scanCppFile(void *opaq, CPlusPlus::Lexer &yylex, bool scanForFileTag
                         else
                             scanResult.flags = SC_GLOBAL_INCLUDE_FLAG;
                         scanResult.fileName = opaque->fileContent + tk.begin() + 1;
-                        opaque->includedFiles.append(scanResult);
+                        opaque->includedFiles.push_back(scanResult);
                     }
                 }
             }