diff options
author | Ivan Komissarov <ABBAPOH@gmail.com> | 2019-05-19 02:01:24 +0200 |
---|---|---|
committer | Ivan Komissarov <ABBAPOH@gmail.com> | 2019-05-20 15:59:17 +0000 |
commit | b26d45671efe2ac7ad6e0fc5a1e372caf82f8bc9 (patch) | |
tree | c6d30dffb434c7480163891c81c18f5c1a2166a2 /src | |
parent | f88fbf2c88af7348dbd205ccd7a994f6306526f2 (diff) |
Fix -Wclazy-inefficient-qlist-soft
QLists were used with types that bigger than sizeof(void*) which lead to
extra allocations
Change-Id: Id716c6b4919f9a0ad62e1d2972319a600785afc5
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src')
-rw-r--r-- | src/lib/corelib/buildgraph/executor.cpp | 2 | ||||
-rw-r--r-- | src/lib/corelib/buildgraph/rulesapplicator.cpp | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/corelib/buildgraph/executor.cpp b/src/lib/corelib/buildgraph/executor.cpp index 24405ec5b..7d53351c2 100644 --- a/src/lib/corelib/buildgraph/executor.cpp +++ b/src/lib/corelib/buildgraph/executor.cpp @@ -1084,7 +1084,7 @@ void Executor::checkForUnbuiltProducts() { if (m_buildOptions.executeRulesOnly()) return; - QList<ResolvedProductPtr> unbuiltProducts; + std::vector<ResolvedProductPtr> unbuiltProducts; for (const ResolvedProductPtr &product : m_productsToBuild) { bool productBuilt = true; for (BuildGraphNode *rootNode : qAsConst(product->buildData->rootNodes())) { diff --git a/src/lib/corelib/buildgraph/rulesapplicator.cpp b/src/lib/corelib/buildgraph/rulesapplicator.cpp index 406f92783..16aa0c001 100644 --- a/src/lib/corelib/buildgraph/rulesapplicator.cpp +++ b/src/lib/corelib/buildgraph/rulesapplicator.cpp @@ -188,7 +188,7 @@ void RulesApplicator::doApply(const ArtifactSet &inputArtifacts, QScriptValue &p qCDebug(lcBuildGraph) << "apply rule" << m_rule->toString() << toStringList(inputArtifacts).join(QLatin1String(",\n ")); - QList<std::pair<const RuleArtifact *, OutputArtifactInfo>> ruleArtifactArtifactMap; + std::vector<std::pair<const RuleArtifact *, OutputArtifactInfo>> ruleArtifactArtifactMap; QList<Artifact *> outputArtifacts; m_transformer = Transformer::create(); |