diff options
author | hjk <hjk@qt.io> | 2019-03-04 09:31:42 +0100 |
---|---|---|
committer | hjk <hjk@qt.io> | 2019-03-04 12:17:43 +0000 |
commit | d596d72ae8fdb1e936eafadd94004cdea3b4ab64 (patch) | |
tree | 731b146e926e543a6a93394710d28ddb85485d9d /src | |
parent | 50eb4d183ccb526874cefe73c7f4c2129769aa4a (diff) |
Fix some warnings
None of them really necessary or even desirable to fix, but...
tools/launcherinterface.cpp:114:80: warning: ‘void QProcess::finished(int)’ is deprecated:
Use QProcess::finished(int, QProcess::ExitStatus) instead [-Wdeprecated-declarations]
api/projectdata.cpp: In function ‘QString qbs::mapToString(const QVariantMap&, const QString&)’:
api/projectdata.cpp:882:15: warning: ‘void qSort(Container&) [with Container = QStringList]’
is deprecated: Use std::sort [-Wdeprecated-declarations]
parser/qmljsparser.cpp: In member function ‘void QbsQmlJS::Parser::reallocateStack()’:
parser/qmljsparser.cpp:72:104: warning: ‘void* realloc(void*, size_t)’ moving an object of non-trivially copyable type ‘class QStringRef’; use ‘new’ and ‘delete’ instead [-Wclass-memaccess]
etc.
The QStringRef is the only one theoretically applicable, but isn't in
practice given the current implementation.
Change-Id: Idb2a03e3fd096b6ad428615f81266f952d2a8d95
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src')
-rw-r--r-- | src/app/qbs/status.cpp | 2 | ||||
-rw-r--r-- | src/lib/corelib/api/project.cpp | 26 | ||||
-rw-r--r-- | src/lib/corelib/api/projectdata.cpp | 2 | ||||
-rw-r--r-- | src/lib/corelib/parser/qmljsparser.cpp | 3 | ||||
-rw-r--r-- | src/lib/corelib/tools/launcherinterface.cpp | 3 | ||||
-rw-r--r-- | src/libexec/qbs_processlauncher/launchersockethandler.cpp | 2 |
6 files changed, 22 insertions, 16 deletions
diff --git a/src/app/qbs/status.cpp b/src/app/qbs/status.cpp index 79a75c673..3dc540ff5 100644 --- a/src/app/qbs/status.cpp +++ b/src/app/qbs/status.cpp @@ -145,7 +145,7 @@ int printStatus(const ProjectData &project) << " (" << group.location().filePath() << ":" << group.location().line() << ")"; QStringList sourceFiles = group.allFilePaths(); - qSort(sourceFiles); + std::sort(sourceFiles.begin(), sourceFiles.end()); for (const QString &sourceFile : qAsConst(sourceFiles)) { if (!QFileInfo(sourceFile).exists()) missingFiles.push_back(sourceFile); diff --git a/src/lib/corelib/api/project.cpp b/src/lib/corelib/api/project.cpp index abb053991..42591ce2f 100644 --- a/src/lib/corelib/api/project.cpp +++ b/src/lib/corelib/api/project.cpp @@ -281,8 +281,10 @@ GroupData ProjectPrivate::createGroupDataFromGroup(const GroupPtr &resolvedGroup group.d->sourceArtifactsFromWildcards.push_back(artifact); } } - qSort(group.d->sourceArtifacts); - qSort(group.d->sourceArtifactsFromWildcards); + std::sort(group.d->sourceArtifacts.begin(), + group.d->sourceArtifacts.end()); + std::sort(group.d->sourceArtifactsFromWildcards.begin(), + group.d->sourceArtifactsFromWildcards.end()); group.d->properties.d->m_map = resolvedGroup->properties; group.d->isEnabled = resolvedGroup->enabled; group.d->isValid = true; @@ -380,8 +382,9 @@ void ProjectPrivate::addGroup(const ProductData &product, const QString &groupNa resolvedGroup->properties = resolvedProducts[i]->moduleProperties; resolvedGroup->overrideTags = false; resolvedProducts.at(i)->groups << resolvedGroup; - products.at(i).d->groups << createGroupDataFromGroup(resolvedGroup, resolvedProducts.at(i)); - qSort(products.at(i).d->groups); + QList<GroupData> &groupData = products.at(i).d->groups; + groupData << createGroupDataFromGroup(resolvedGroup, resolvedProducts.at(i)); + std::sort(groupData.begin(), groupData.end()); } } @@ -556,9 +559,10 @@ void ProjectPrivate::addFiles(const ProductData &product, const GroupData &group } for (const GroupData &g : qAsConst(groupContext.groups)) { g.d->sourceArtifacts << sourceArtifacts; - qSort(g.d->sourceArtifacts); + std::sort(g.d->sourceArtifacts.begin(), g.d->sourceArtifacts.end()); g.d->sourceArtifactsFromWildcards << sourceArtifactsFromWildcards; - qSort(g.d->sourceArtifactsFromWildcards); + std::sort(g.d->sourceArtifactsFromWildcards.begin(), + g.d->sourceArtifactsFromWildcards.end()); } } @@ -887,9 +891,9 @@ void ProjectPrivate::retrieveProjectData(ProjectData &projectData, : qAsConst(resolvedProduct->dependencies)) { product.d->dependencies << resolvedDependentProduct->name; } - qSort(product.d->type); - qSort(product.d->groups); - qSort(product.d->generatedArtifacts); + std::sort(product.d->type.begin(), product.d->type.end()); + std::sort(product.d->groups.begin(), product.d->groups.end()); + std::sort(product.d->generatedArtifacts.begin(), product.d->generatedArtifacts.end()); product.d->isValid = true; projectData.d->products << product; } @@ -902,8 +906,8 @@ void ProjectPrivate::retrieveProjectData(ProjectData &projectData, projectData.d->subProjects << subProject; } projectData.d->isValid = true; - qSort(projectData.d->products); - qSort(projectData.d->subProjects); + std::sort(projectData.d->products.begin(), projectData.d->products.end()); + std::sort(projectData.d->subProjects.begin(), projectData.d->subProjects.end()); } } // namespace Internal diff --git a/src/lib/corelib/api/projectdata.cpp b/src/lib/corelib/api/projectdata.cpp index a3e6eac25..0c3ba186d 100644 --- a/src/lib/corelib/api/projectdata.cpp +++ b/src/lib/corelib/api/projectdata.cpp @@ -879,7 +879,7 @@ QVariant PropertyMap::getModuleProperty(const QString &moduleName, static QString mapToString(const QVariantMap &map, const QString &prefix) { QStringList keys(map.keys()); - qSort(keys); + std::sort(keys.begin(), keys.end()); QString stringRep; for (const QString &key : qAsConst(keys)) { const QVariant &val = map.value(key); diff --git a/src/lib/corelib/parser/qmljsparser.cpp b/src/lib/corelib/parser/qmljsparser.cpp index e90f3af9d..71cff876d 100644 --- a/src/lib/corelib/parser/qmljsparser.cpp +++ b/src/lib/corelib/parser/qmljsparser.cpp @@ -69,7 +69,8 @@ void Parser::reallocateStack() sym_stack = reinterpret_cast<Value*> (realloc(sym_stack, stack_size * sizeof(Value))); state_stack = reinterpret_cast<int*> (realloc(state_stack, stack_size * sizeof(int))); location_stack = reinterpret_cast<AST::SourceLocation*> (realloc(location_stack, stack_size * sizeof(AST::SourceLocation))); - string_stack = reinterpret_cast<QStringRef*> (realloc(string_stack, stack_size * sizeof(QStringRef))); + string_stack = reinterpret_cast<QStringRef*> (realloc( + static_cast<void *>(string_stack), stack_size * sizeof(QStringRef))); } Parser::Parser(Engine *engine): diff --git a/src/lib/corelib/tools/launcherinterface.cpp b/src/lib/corelib/tools/launcherinterface.cpp index f635ef250..b16c8563c 100644 --- a/src/lib/corelib/tools/launcherinterface.cpp +++ b/src/lib/corelib/tools/launcherinterface.cpp @@ -111,7 +111,8 @@ void LauncherInterface::doStart() connect(m_process, static_cast<void (QProcess::*)(QProcess::ProcessError)>(&QProcess::error), this, &LauncherInterface::handleProcessError); - connect(m_process, static_cast<void (QProcess::*)(int)>(&QProcess::finished), + connect(m_process, + static_cast<void (QProcess::*)(int, QProcess::ExitStatus)>(&QProcess::finished), this, &LauncherInterface::handleProcessFinished); connect(m_process, &QProcess::readyReadStandardError, this, &LauncherInterface::handleProcessStderr); diff --git a/src/libexec/qbs_processlauncher/launchersockethandler.cpp b/src/libexec/qbs_processlauncher/launchersockethandler.cpp index 54951a586..a6f7843ec 100644 --- a/src/libexec/qbs_processlauncher/launchersockethandler.cpp +++ b/src/libexec/qbs_processlauncher/launchersockethandler.cpp @@ -275,7 +275,7 @@ Process *LauncherSocketHandler::setupProcess(quintptr token) const auto p = new Process(token, this); connect(p, static_cast<void (QProcess::*)(QProcess::ProcessError)>(&QProcess::error), this, &LauncherSocketHandler::handleProcessError); - connect(p, static_cast<void (QProcess::*)(int)>(&QProcess::finished), + connect(p, static_cast<void (QProcess::*)(int, QProcess::ExitStatus)>(&QProcess::finished), this, &LauncherSocketHandler::handleProcessFinished); connect(p, &Process::failedToStop, this, &LauncherSocketHandler::handleStopFailure); return p; |